nick/amethyst
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

fix NestViewModelTest for sender-grouped reaction aggregator

Browse Source 
onReactionEventGroupsByTargetAndEvictsOnTick asserted the pre-change
targetPubkey grouping (recentReactions.value[bob]); the aggregator
now groups by sourcePubkey so the chip rises from the reactor's
avatar. Renamed to ...GroupsBySender and assert under alice's key.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Vitor Pamplona
2026-05-14 08:43:52 -04:00
parent 78be534df5
commit 0182439b55
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
commons/src/commonTest/kotlin/com/vitorpamplona/amethyst/commons/viewmodels/NestViewModelTest.kt
+7 -4
View File
@@ -313,7 +313,7 @@ class NestViewModelTest {
} }
@Test @Test
fun onReactionEventGroupsByTargetAndEvictsOnTick() = fun onReactionEventGroupsBySenderAndEvictsOnTick() =
runVmTest { runVmTest {
val vm = newViewModel { FakeNestsListener() } val vm = newViewModel { FakeNestsListener() }
val alice = "a".repeat(64) val alice = "a".repeat(64)
@@ -339,10 +339,13 @@ class NestViewModelTest {
sig = "0".repeat(128), sig = "0".repeat(128),
) )
// Two reactions land within the 30-s window. // Two reactions sent BY alice land within the 30-s window.
// The aggregator groups by sender (so the floating chip
// rises from the reactor's avatar), NOT by the `p`-tag
// target — both land under alice's key.
vm.onReactionEvent(rxn(alice, bob, "🔥", 100L), nowSec = 100L) vm.onReactionEvent(rxn(alice, bob, "🔥", 100L), nowSec = 100L)
vm.onReactionEvent(rxn(alice, bob, "👏", 105L), nowSec = 105L) vm.onReactionEvent(rxn(alice, bob, "👏", 105L), nowSec = 105L)
assertEquals(2, vm.recentReactions.value[bob]!!.size) assertEquals(2, vm.recentReactions.value[alice]!!.size)
// LocalCache.observeEvents re-emits the full matching list // LocalCache.observeEvents re-emits the full matching list
// on every cache mutation; the same kind-7 must collapse // on every cache mutation; the same kind-7 must collapse
@@ -350,7 +353,7 @@ class NestViewModelTest {
val replayed = rxn(alice, bob, "🔥", 100L, id = "f".repeat(64)) val replayed = rxn(alice, bob, "🔥", 100L, id = "f".repeat(64))
vm.onReactionEvent(replayed, nowSec = 105L) vm.onReactionEvent(replayed, nowSec = 105L)
vm.onReactionEvent(replayed, nowSec = 105L) vm.onReactionEvent(replayed, nowSec = 105L)
assertEquals(3, vm.recentReactions.value[bob]!!.size) assertEquals(3, vm.recentReactions.value[alice]!!.size)
// Tick advances past the window — all reactions evicted. // Tick advances past the window — all reactions evicted.
vm.evictReactions(olderThanSec = 200L) vm.evictReactions(olderThanSec = 200L)