From 1cd39e0d8f0253b462911d9d26a5a2d78cdc1854 Mon Sep 17 00:00:00 2001 From: Vitor Pamplona Date: Tue, 13 Jun 2023 16:30:37 -0400 Subject: [PATCH] Removes the use of by on the quick action menu's state because it was triggering recompositions --- .../vitorpamplona/amethyst/ui/note/NoteQuickActionMenu.kt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/src/main/java/com/vitorpamplona/amethyst/ui/note/NoteQuickActionMenu.kt b/app/src/main/java/com/vitorpamplona/amethyst/ui/note/NoteQuickActionMenu.kt index 7640fbc58..d9e77385c 100644 --- a/app/src/main/java/com/vitorpamplona/amethyst/ui/note/NoteQuickActionMenu.kt +++ b/app/src/main/java/com/vitorpamplona/amethyst/ui/note/NoteQuickActionMenu.kt @@ -112,12 +112,12 @@ private fun VerticalDivider(color: Color) = @Composable fun LongPressToQuickAction(baseNote: Note, accountViewModel: AccountViewModel, content: @Composable (() -> Unit) -> Unit) { - var popupExpanded by remember { mutableStateOf(false) } - val showPopup = remember { { popupExpanded = true } } + var popupExpanded = remember { mutableStateOf(false) } + val showPopup = remember(popupExpanded) { { popupExpanded.value = true } } content(showPopup) - NoteQuickActionMenu(baseNote, popupExpanded, { popupExpanded = false }, accountViewModel) + NoteQuickActionMenu(baseNote, popupExpanded.value, { popupExpanded.value = false }, accountViewModel) } @Composable