From 2010e41b2511a3282c4aa33a0b4d094df97ec8cc Mon Sep 17 00:00:00 2001 From: nrobi144 Date: Tue, 19 May 2026 07:59:33 +0300 Subject: [PATCH] fix(ci): allow dpkg post-install error, verify binary extracted dpkg -i exits non-zero when the post-install script fails even with --force-all. Allow the error with || true, then verify the binary was actually extracted to /opt before proceeding. Co-Authored-By: Claude Opus 4.6 (1M context) --- .github/workflows/smoke-test-desktop.yml | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/.github/workflows/smoke-test-desktop.yml b/.github/workflows/smoke-test-desktop.yml index 6223d5daa..c00616a26 100644 --- a/.github/workflows/smoke-test-desktop.yml +++ b/.github/workflows/smoke-test-desktop.yml @@ -125,13 +125,18 @@ jobs: - name: Install .deb run: | - set -euo pipefail - # --force-all: jpackage's post-install script runs xdg-desktop-menu - # which fails on CI runners ("No writable system menu directory"). - # The menu registration is irrelevant for smoke testing. - sudo dpkg -i --force-all desktopApp/build/compose/binaries/main-release/deb/*.deb + # jpackage's post-install script runs xdg-desktop-menu which fails + # on CI runners ("No writable system menu directory"). The files are + # extracted successfully; only the menu registration fails. Allow the + # dpkg error, then verify the binary was actually installed. + sudo dpkg -i desktopApp/build/compose/binaries/main-release/deb/*.deb || true echo "Installed files:" dpkg -L amethyst | head -30 + # Fail if the binary wasn't actually extracted + test -d /opt/amethyst || test -d /opt/Amethyst || { + echo "FAIL: /opt/amethyst not found after dpkg -i" + exit 1 + } - name: Smoke test — app launches and stays alive run: |