From 3dd42492200e9dc80c2e79a7a523149795427be0 Mon Sep 17 00:00:00 2001 From: davotoula Date: Mon, 15 Dec 2025 19:39:24 +0100 Subject: [PATCH] code review: abort posting message if voice upload fails --- .../ui/screen/loggedIn/home/ShortNotePostViewModel.kt | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/amethyst/src/main/java/com/vitorpamplona/amethyst/ui/screen/loggedIn/home/ShortNotePostViewModel.kt b/amethyst/src/main/java/com/vitorpamplona/amethyst/ui/screen/loggedIn/home/ShortNotePostViewModel.kt index b7430793d..a477ddd95 100644 --- a/amethyst/src/main/java/com/vitorpamplona/amethyst/ui/screen/loggedIn/home/ShortNotePostViewModel.kt +++ b/amethyst/src/main/java/com/vitorpamplona/amethyst/ui/screen/loggedIn/home/ShortNotePostViewModel.kt @@ -486,10 +486,15 @@ open class ShortNotePostViewModel : val serverToUse = voiceSelectedServer ?: accountViewModel.account.settings.defaultFileServer uploadVoiceMessageSync( serverToUse, - { _, _ -> }, // Ignore errors during sync upload before post + { _, _ -> }, // Error handling is done by checking voiceMetadata below ) + // Abort if upload failed - don't post without voice data + if (voiceMetadata == null) { + Log.w("ShortNotePostViewModel", "Voice upload failed, aborting post") + return + } // Update default server if voice message was successfully uploaded - if (voiceMetadata != null && voiceSelectedServer != null && voiceSelectedServer?.type != ServerType.NIP95) { + if (voiceSelectedServer != null && voiceSelectedServer?.type != ServerType.NIP95) { account.settings.changeDefaultFileServer(voiceSelectedServer!!) } }