nick/amethyst
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

fix(packaging): add trap cleanup and xz compression to deb rewriter

Browse Source 
Address review findings:
- Add trap for temp dir cleanup on error
- Use -Zxz for max distro compatibility (older dpkg lacks zstd)
- Use --root-owner-group for correct file ownership

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
nrobi144
2026-04-27 10:39:24 +03:00
parent c1c52aa022
commit 450c740c62
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/relax-deb-libicu.sh
+3 -1
View File
@@ -26,16 +26,18 @@ for deb in "$@"; do
fi fi
work="$(mktemp -d)" work="$(mktemp -d)"
trap 'rm -rf "$work"' EXIT
dpkg-deb -R "$deb" "$work/pkg" dpkg-deb -R "$deb" "$work/pkg"
control="$work/pkg/DEBIAN/control" control="$work/pkg/DEBIAN/control"
if grep -qE 'libicu[0-9]+' "$control"; then if grep -qE 'libicu[0-9]+' "$control"; then
sed -i -E "s/libicu[0-9]+([[:space:]]*\\|[[:space:]]*libicu[0-9]+)*/${ALT}/g" "$control" sed -i -E "s/libicu[0-9]+([[:space:]]*\\|[[:space:]]*libicu[0-9]+)*/${ALT}/g" "$control"
dpkg-deb -b "$work/pkg" "$deb" >/dev/null dpkg-deb --root-owner-group -Zxz -b "$work/pkg" "$deb" >/dev/null
echo "Relaxed libicu dep: $deb" echo "Relaxed libicu dep: $deb"
else else
echo "No libicu dep, leaving as-is: $deb" echo "No libicu dep, leaving as-is: $deb"
fi fi
rm -rf "$work" rm -rf "$work"
trap - EXIT
done done