nick/amethyst
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Avoids flickering the screen when the update from Loading to Loaded happens on cached objects.

Browse Source
This commit is contained in:
Vitor Pamplona
2023-03-01 09:34:14 -05:00
parent e0596dc3b9
commit 459e503c8a
1 changed files with 20 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/src/main/java/com/vitorpamplona/amethyst/ui/components/UrlPreview.kt
+20 -17
View File
@@ -16,24 +16,29 @@ import kotlinx.coroutines.withContext
@Composable @Composable
fun UrlPreview(url: String, urlText: String, showUrlIfError: Boolean = true) { fun UrlPreview(url: String, urlText: String) {
var urlPreviewState by remember { mutableStateOf<UrlPreviewState>(UrlPreviewState.Loading) } val default = UrlCachedPreviewer.cache[url]?.let { UrlPreviewState.Loaded(it) } ?: UrlPreviewState.Loading
var urlPreviewState by remember { mutableStateOf(default) }
// Doesn't use a viewModel because of viewModel reusing issues (too many UrlPreview are created). // Doesn't use a viewModel because of viewModel reusing issues (too many UrlPreview are created).
LaunchedEffect(url) { LaunchedEffect(url) {
withContext(Dispatchers.IO) { if (urlPreviewState == UrlPreviewState.Loading) {
UrlCachedPreviewer.previewInfo(url, object : IUrlPreviewCallback { withContext(Dispatchers.IO) {
override fun onComplete(urlInfo: UrlInfoItem) { UrlCachedPreviewer.previewInfo(url, object : IUrlPreviewCallback {
if (urlInfo.allFetchComplete() && urlInfo.url == url) override fun onComplete(urlInfo: UrlInfoItem) {
urlPreviewState = UrlPreviewState.Loaded(urlInfo) if (urlInfo.allFetchComplete() && urlInfo.url == url)
else urlPreviewState = UrlPreviewState.Loaded(urlInfo)
urlPreviewState = UrlPreviewState.Empty else
} urlPreviewState = UrlPreviewState.Empty
}
override fun onFailed(throwable: Throwable) { override fun onFailed(throwable: Throwable) {
urlPreviewState = UrlPreviewState.Error("Error parsing preview for ${url}: ${throwable.message}") urlPreviewState =
} UrlPreviewState.Error("Error parsing preview for ${url}: ${throwable.message}")
}) }
})
}
} }
} }
@@ -43,9 +48,7 @@ fun UrlPreview(url: String, urlText: String, showUrlIfError: Boolean = true) {
UrlPreviewCard(url, state.previewInfo) UrlPreviewCard(url, state.previewInfo)
} }
else -> { else -> {
if (showUrlIfError) { ClickableUrl(urlText, url)
ClickableUrl(urlText, url)
}
} }
} }
} }