nick/amethyst
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Merge pull request #2590 from vitorpamplona/claude/fix-fdroid-lint-errors-i6aEY

Browse Source 
fix(playback): hoist DataSourceBitmapLoader build into a function
This commit is contained in:
Vitor Pamplona
2026-04-26 13:59:51 -04:00
committed by GitHub
parent 6540b81512 179642d78b
commit 49f769f92a
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
amethyst/src/main/java/com/vitorpamplona/amethyst/service/playback/playerPool/MediaSessionPool.kt
+5 -2
View File
@@ -83,14 +83,17 @@ class MediaSessionPool(
// The bitmap loader is stateless w.r.t. the session; a fresh allocation per session was // The bitmap loader is stateless w.r.t. the session; a fresh allocation per session was
// pure noise. ExoPlayer's DEFAULT_EXECUTOR_SERVICE is a process-wide singleton, the // pure noise. ExoPlayer's DEFAULT_EXECUTOR_SERVICE is a process-wide singleton, the
// dataSourceFactory is owned by the pool, and the appContext is already retained. // dataSourceFactory is owned by the pool, and the appContext is already retained.
// The init is in a separate function so the @OptIn lands on a real declaration —
// applying it to a `by lazy` property doesn't propagate into the lambda body.
private val sharedBitmapLoader by lazy { buildSharedBitmapLoader() }
@OptIn(UnstableApi::class) @OptIn(UnstableApi::class)
private val sharedBitmapLoader by lazy { private fun buildSharedBitmapLoader(): DataSourceBitmapLoader =
DataSourceBitmapLoader DataSourceBitmapLoader
.Builder(appContext) .Builder(appContext)
.setExecutorService(DataSourceBitmapLoader.DEFAULT_EXECUTOR_SERVICE.get()) .setExecutorService(DataSourceBitmapLoader.DEFAULT_EXECUTOR_SERVICE.get())
.setDataSourceFactory(dataSourceFactory) .setDataSourceFactory(dataSourceFactory)
.build() .build()
}
// protects from LruCache killing playing sessions // protects from LruCache killing playing sessions
private val playingMap = mutableMapOf<String, SessionListener>() private val playingMap = mutableMapOf<String, SessionListener>()