From 5fa648f2fb45dff0c57ccbe56f19fae41d40aac4 Mon Sep 17 00:00:00 2001 From: Claude Date: Thu, 7 May 2026 15:38:34 +0000 Subject: [PATCH] =?UTF-8?q?fix(quic-interop):=20inspect=20=E2=80=94=20skip?= =?UTF-8?q?=20non-dir=20matches=20of=20run-*=20glob?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The 'run-.stdout.log' siblings also match the 'run-*' glob — zsh in particular returns them mixed with the actual run dirs. The for-loop now filters to directories only. (The summarize-matrix script was already OK — it does ls -1d followed by a head -1, and run dirs come first in mtime order.) --- quic/interop/inspect-testcase.sh | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/quic/interop/inspect-testcase.sh b/quic/interop/inspect-testcase.sh index 85543b5f3..f262f0850 100755 --- a/quic/interop/inspect-testcase.sh +++ b/quic/interop/inspect-testcase.sh @@ -20,12 +20,11 @@ RUNNER_LOGS="${REPO_ROOT}/../quic-interop-runner/logs" # Most recent run dir that has the named testcase. RUN_DIR="" +# Filter to actual directories — zsh's glob also matches the +# sibling .stdout.log files that run-matrix.sh tees, which start +# with the same 'run-' prefix and would resolve as not-a-dir. for d in $(ls -1dt "$RUNNER_LOGS"/run-* 2>/dev/null); do - if [[ -d "$d"/*amethyst*/"$TC" ]] 2>/dev/null; then - RUN_DIR="$d" - break - fi - # Fallback for shells that don't expand the glob in the test: + [[ -d "$d" ]] || continue if ls -d "$d"/*amethyst*/"$TC" >/dev/null 2>&1; then RUN_DIR="$d" break