Reject bogus Content-Type when saving downloaded media

Code review:
- also validate URL-extension fallback as a media type
- hoist trimInlineMetaData + drop !! on mimeType

amethyst/src/main/java/com/vitorpamplona/amethyst/ui/actions/MediaSaverToDisk.kt

@@ -111,26 +111,30 @@ object MediaSaverToDisk {
                 withContext(Dispatchers.IO) {
                     check(response.isSuccessful)
 
+                    val trimmedUrl = trimInlineMetaData(url)
                     if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q) {
-                        val contentType = response.header("Content-Type") ?: getMimeTypeFromExtension(trimInlineMetaData(url))
+                        val headerType =
-                        check(contentType.isNotBlank()) { "Can't find out the content type" }
+                            response
+                                .header("Content-Type")
+                                ?.substringBefore(";")
+                                ?.trim()
 
                         val realType =
-                            if (contentType == "application/octet-stream") {
+                            headerType?.takeIf(::isMediaMimeType)
-                                mimeType ?: getMimeTypeFromExtension(url)
+                                ?: mimeType?.takeIf(::isMediaMimeType)
-                            } else {
+                                ?: getMimeTypeFromExtension(trimmedUrl).takeIf(::isMediaMimeType)
-                                contentType
+                                ?: ""
-                            }
+                        check(realType.isNotBlank()) { "Can't find out the content type" }
 
                         saveContentQ(
-                            displayName = File(trimInlineMetaData(url)).nameWithoutExtension,
+                            displayName = File(trimmedUrl).nameWithoutExtension,
                             contentType = realType,
                             contentSource = response.body.source(),
                             contentResolver = context.contentResolver,
                         )
                     } else {
                         saveContentDefault(
-                            fileName = File(trimInlineMetaData(url)).name,
+                            fileName = File(trimmedUrl).name,
                             contentSource = response.body.source(),
                             context = context,
                         )
@@ -150,6 +154,14 @@ object MediaSaverToDisk {
             MimeTypeMap.getSingleton().getMimeTypeFromExtension(it).orEmpty()
         }
 
+    private fun isMediaMimeType(type: String): Boolean =
+        type.isNotBlank() &&
+            (
+                type.startsWith("image/", ignoreCase = true) ||
+                    type.startsWith("video/", ignoreCase = true) ||
+                    type.startsWith("audio/", ignoreCase = true)
+            )
+
     @OptIn(ExperimentalUuidApi::class)
     fun save(
         localFile: File,