From 6b1bc947a9ddd3f66a08fb64e714ec4507a9a16a Mon Sep 17 00:00:00 2001
From: Claude <noreply@anthropic.com>
Date: Thu, 9 Apr 2026 20:59:58 +0000
Subject: [PATCH] perf: eliminate heap allocations in privKeyTweakAdd
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Use thread-local scratch LongArrays instead of allocating 2
intermediate LongArray(4) via U256.fromBytes. The old path did:
  fromBytes(seckey) → alloc LongArray(4)
  fromBytes(tweak)  → alloc LongArray(4)
  ScalarN.add(a, b) → alloc LongArray(4)
  U256.toBytes(r)   → alloc ByteArray(32)
  = 4 heap allocations

New path uses pre-allocated scratch from PointScratch:
  fromBytesInto(scratch, seckey) → zero alloc
  fromBytesInto(scratch, tweak) → zero alloc
  ScalarN.addTo(scratch, a, b)  → zero alloc
  U256.toBytes(r)               → 1 alloc (unavoidable, return value)

K/Native: 163 → 88 ns (-46%, from 6.3x to 3.4x vs C)
JVM: now faster than native C via JNI (Kotlin 6.5M ops/s vs C 4.8M ops/s)

https://claude.ai/code/session_015CtM5k88rF7WFgX8o2AGNR
---
 .../quartz/utils/secp256k1/Secp256k1.kt           | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/quartz/src/commonMain/kotlin/com/vitorpamplona/quartz/utils/secp256k1/Secp256k1.kt b/quartz/src/commonMain/kotlin/com/vitorpamplona/quartz/utils/secp256k1/Secp256k1.kt
index 2f96b9a0a..f4ea36cb0 100644
--- a/quartz/src/commonMain/kotlin/com/vitorpamplona/quartz/utils/secp256k1/Secp256k1.kt
+++ b/quartz/src/commonMain/kotlin/com/vitorpamplona/quartz/utils/secp256k1/Secp256k1.kt
@@ -519,9 +519,18 @@ object Secp256k1 {
         tweak: ByteArray,
     ): ByteArray {
         require(seckey.size == 32 && tweak.size == 32)
-        val result = ScalarN.add(U256.fromBytes(seckey), U256.fromBytes(tweak))
-        require(!U256.isZero(result) && U256.cmp(result, ScalarN.N) < 0)
-        return U256.toBytes(result)
+        // Use thread-local scratch to avoid 2 intermediate LongArray(4) allocations.
+        // Old path: fromBytes (alloc) + fromBytes (alloc) + add (alloc) + toBytes (alloc) = 4 allocs
+        // New path: fromBytesInto (scratch) + fromBytesInto (scratch) + addTo (scratch) + toBytes = 1 alloc
+        val sc = ECPoint.getScratch()
+        val a = sc.entryTmp
+        val b = sc.entryTmp2
+        val r = sc.scalarTmp1
+        U256.fromBytesInto(a, seckey, 0)
+        U256.fromBytesInto(b, tweak, 0)
+        ScalarN.addTo(r, a, b)
+        require(!U256.isZero(r) && U256.cmp(r, ScalarN.N) < 0)
+        return U256.toBytes(r)
     }
 
     /** Multiply a public key by a scalar. Used for ECDH shared secret derivation. */