From 7c63d654f2d082f0632a1a6583e3eea9944dd0ff Mon Sep 17 00:00:00 2001
From: Vitor Pamplona <vitor@vitorpamplona.com>
Date: Thu, 1 Jan 2026 21:29:20 -0500
Subject: [PATCH] Inverts the name of the isFilledFilter function

---
 .../nip01Core/store/sqlite/QueryBuilder.kt    |  2 +-
 .../relay/client/pool/RelayBasedFilter.kt     |  6 ++---
 .../quartz/nip01Core/relay/filters/Filter.kt  | 22 +++++++++----------
 3 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/quartz/src/androidMain/kotlin/com/vitorpamplona/quartz/nip01Core/store/sqlite/QueryBuilder.kt b/quartz/src/androidMain/kotlin/com/vitorpamplona/quartz/nip01Core/store/sqlite/QueryBuilder.kt
index 0fc2cc569..29bbf3f54 100644
--- a/quartz/src/androidMain/kotlin/com/vitorpamplona/quartz/nip01Core/store/sqlite/QueryBuilder.kt
+++ b/quartz/src/androidMain/kotlin/com/vitorpamplona/quartz/nip01Core/store/sqlite/QueryBuilder.kt
@@ -327,7 +327,7 @@ class QueryBuilder(
         filter: Filter,
         hasher: TagNameValueHasher,
     ): QuerySpec? {
-        if (!filter.isFilledFilter()) return null
+        if (filter.isEmpty()) return null
 
         val mustJoinSearch = (filter.search != null)
 
diff --git a/quartz/src/commonMain/kotlin/com/vitorpamplona/quartz/nip01Core/relay/client/pool/RelayBasedFilter.kt b/quartz/src/commonMain/kotlin/com/vitorpamplona/quartz/nip01Core/relay/client/pool/RelayBasedFilter.kt
index ba5b30576..584df7a8f 100644
--- a/quartz/src/commonMain/kotlin/com/vitorpamplona/quartz/nip01Core/relay/client/pool/RelayBasedFilter.kt
+++ b/quartz/src/commonMain/kotlin/com/vitorpamplona/quartz/nip01Core/relay/client/pool/RelayBasedFilter.kt
@@ -35,10 +35,10 @@ class RelayBasedFilter(
 fun List<RelayBasedFilter>.groupByRelay(): Map<NormalizedRelayUrl, List<Filter>> {
     val result = mutableMapOf<NormalizedRelayUrl, MutableList<Filter>>()
     for (relayBasedFilter in this) {
-        if (relayBasedFilter.filter.isFilledFilter()) {
-            result.getOrPut(relayBasedFilter.relay) { mutableListOf() }.add(relayBasedFilter.filter)
-        } else {
+        if (relayBasedFilter.filter.isEmpty()) {
             Log.e("FilterError", "Ignoring empty filter for ${relayBasedFilter.relay}")
+        } else {
+            result.getOrPut(relayBasedFilter.relay) { mutableListOf() }.add(relayBasedFilter.filter)
         }
     }
     return result
diff --git a/quartz/src/commonMain/kotlin/com/vitorpamplona/quartz/nip01Core/relay/filters/Filter.kt b/quartz/src/commonMain/kotlin/com/vitorpamplona/quartz/nip01Core/relay/filters/Filter.kt
index 8872600d1..eae7fc8e9 100644
--- a/quartz/src/commonMain/kotlin/com/vitorpamplona/quartz/nip01Core/relay/filters/Filter.kt
+++ b/quartz/src/commonMain/kotlin/com/vitorpamplona/quartz/nip01Core/relay/filters/Filter.kt
@@ -74,18 +74,18 @@ class Filter(
     ) = Filter(ids, authors, kinds, tags, tagsAll, since, until, limit, search)
 
     /**
-     * Returns true if this filter contains any non-null and non-empty criteria.
+     * Returns true if this filter doesn't filter for anything.
      */
-    fun isFilledFilter() =
-        (ids != null && ids.isNotEmpty()) ||
-            (authors != null && authors.isNotEmpty()) ||
-            (kinds != null && kinds.isNotEmpty()) ||
-            (tags != null && tags.isNotEmpty() && tags.values.all { it.isNotEmpty() }) ||
-            (tagsAll != null && tagsAll.isNotEmpty() && tagsAll.values.all { it.isNotEmpty() }) ||
-            (since != null) ||
-            (until != null) ||
-            (limit != null) ||
-            (search != null && search.isNotEmpty())
+    fun isEmpty() =
+        (ids == null || ids.isEmpty()) &&
+            (authors == null || authors.isEmpty()) &&
+            (kinds == null || kinds.isEmpty()) &&
+            (tags == null || tags.isEmpty() && tags.values.all { it.isNotEmpty() }) &&
+            (tagsAll == null || tagsAll.isEmpty() && tagsAll.values.all { it.isNotEmpty() }) &&
+            (since == null) &&
+            (until == null) &&
+            (limit == null) &&
+            (search == null || search.isEmpty())
 
     init {
         ids?.forEach {