From 8588c9a6fcdc882411e35d7aa136901d0b1a65c6 Mon Sep 17 00:00:00 2001 From: davotoula Date: Mon, 22 Sep 2025 19:52:59 +0200 Subject: [PATCH] update plan --- .../vitorpamplona/amethyst/service/uploads/MediaCompressor.kt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/amethyst/src/main/java/com/vitorpamplona/amethyst/service/uploads/MediaCompressor.kt b/amethyst/src/main/java/com/vitorpamplona/amethyst/service/uploads/MediaCompressor.kt index 3551c70b0..8f46b9097 100644 --- a/amethyst/src/main/java/com/vitorpamplona/amethyst/service/uploads/MediaCompressor.kt +++ b/amethyst/src/main/java/com/vitorpamplona/amethyst/service/uploads/MediaCompressor.kt @@ -169,8 +169,10 @@ private fun getVideoInfo( /** The plan * xxx 1. Check input resolution and input fps * xxx 2. Create configuration matrix: for each quality level, set bitrate based on input resolution - * 3. Create Configuration with no quality setting, a bitrate setting, resizer, streamable = true, isMinBitrateCheckEnabled=false + * xxx 3. Create Configuration with no quality setting, a bitrate setting, resizer, streamable = true, isMinBitrateCheckEnabled=false * 4. Don't upload converted file if compression results in larger file (return MediaCompressorResult(uri, contentType, null)) + * xxx 5. Add toast message about file size saving + * 7. refactor (helper class for video compression) * * * Don't use Configuration.quality which only determines bitrate. Instead let's create aggressive bitrates based on input and selected quality