feat: NIP-89 compliance fixes, modernize package structure, link NIP-88 polls

Fix PlatformLinkTag.parse() off-by-one bug where tag indices were shifted (platform/uri/entityType read from wrong positions). Add missing TagArrayExt and EventExt files for definition and recommendation packages to align with the modern pattern used by nip88Polls. Parameterize DiscoverNIP89FeedFilter by targetKind and create NIP-89 poll app discovery infrastructure linking NIP-88 polls (kind 1068) to the NIP-89 app handler discovery system. https://claude.ai/code/session_013r2LXj11SieWa5PaLesKfC
2026-03-30 03:49:21 +00:00
parent 35d677f531
commit 940e59b323
11 changed files with 465 additions and 8 deletions
@@ -0,0 +1,23 @@
+/*
+ * Copyright (c) 2025 Vitor Pamplona
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy of
+ * this software and associated documentation files (the "Software"), to deal in
+ * the Software without restriction, including without limitation the rights to use,
+ * copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the
+ * Software, and to permit persons to whom the Software is furnished to do so,
+ * subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in all
+ * copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
+ * FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
+ * COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN
+ * AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
+ * WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+ */
+package com.vitorpamplona.quartz.nip89AppHandlers.definition
+
+fun AppDefinitionEvent.platformLinks() = tags.platformLinks()
@@ -0,0 +1,26 @@
+/*
+ * Copyright (c) 2025 Vitor Pamplona
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy of
+ * this software and associated documentation files (the "Software"), to deal in
+ * the Software without restriction, including without limitation the rights to use,
+ * copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the
+ * Software, and to permit persons to whom the Software is furnished to do so,
+ * subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in all
+ * copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
+ * FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
+ * COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN
+ * AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
+ * WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+ */
+package com.vitorpamplona.quartz.nip89AppHandlers.definition
+
+import com.vitorpamplona.quartz.nip01Core.core.TagArray
+import com.vitorpamplona.quartz.nip89AppHandlers.definition.tags.PlatformLinkTag
+
+fun TagArray.platformLinks() = this.mapNotNull(PlatformLinkTag::parse)
@@ -41,7 +41,7 @@ class PlatformLinkTag(
            }

        fun parse(tag: Tag): PlatformLinkTag? {
-            if (match(tag)) return PlatformLinkTag(tag[1], tag[2], tag.getOrNull(3))
+            if (match(tag)) return PlatformLinkTag(tag[0], tag[1], tag.getOrNull(2))
            return null
        }

@@ -0,0 +1,28 @@
+/*
+ * Copyright (c) 2025 Vitor Pamplona
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy of
+ * this software and associated documentation files (the "Software"), to deal in
+ * the Software without restriction, including without limitation the rights to use,
+ * copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the
+ * Software, and to permit persons to whom the Software is furnished to do so,
+ * subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in all
+ * copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
+ * FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
+ * COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN
+ * AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
+ * WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+ */
+package com.vitorpamplona.quartz.nip89AppHandlers.recommendation
+
+import com.vitorpamplona.quartz.nip01Core.core.TagArray
+import com.vitorpamplona.quartz.nip89AppHandlers.recommendation.tags.RecommendationTag
+
+fun TagArray.recommendations() = this.mapNotNull(RecommendationTag::parse)
+
+fun TagArray.recommendationAddresses() = this.mapNotNull(RecommendationTag::parseAddressId)
@@ -0,0 +1,97 @@
+/*
+ * Copyright (c) 2025 Vitor Pamplona
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy of
+ * this software and associated documentation files (the "Software"), to deal in
+ * the Software without restriction, including without limitation the rights to use,
+ * copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the
+ * Software, and to permit persons to whom the Software is furnished to do so,
+ * subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in all
+ * copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
+ * FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
+ * COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN
+ * AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
+ * WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+ */
+package com.vitorpamplona.quartz.nip89AppHandlers.definition
+
+import com.vitorpamplona.quartz.nip89AppHandlers.definition.tags.PlatformLinkTag
+import kotlin.test.Test
+import kotlin.test.assertEquals
+import kotlin.test.assertNotNull
+import kotlin.test.assertNull
+
+class PlatformLinkTagTest {
+    @Test
+    fun parsesWebPlatformLinkWithEntityType() {
+        val tag = arrayOf("web", "https://example.com/a/<bech32>", "nevent")
+        val result = PlatformLinkTag.parse(tag)
+
+        assertNotNull(result)
+        assertEquals("web", result.platform)
+        assertEquals("https://example.com/a/<bech32>", result.uri)
+        assertEquals("nevent", result.entityType)
+    }
+
+    @Test
+    fun parsesAndroidPlatformLink() {
+        val tag = arrayOf("android", "amethyst://note/<bech32>", "note")
+        val result = PlatformLinkTag.parse(tag)
+
+        assertNotNull(result)
+        assertEquals("android", result.platform)
+        assertEquals("amethyst://note/<bech32>", result.uri)
+        assertEquals("note", result.entityType)
+    }
+
+    @Test
+    fun parsesIosPlatformLink() {
+        val tag = arrayOf("ios", "damus://note/<bech32>", "naddr")
+        val result = PlatformLinkTag.parse(tag)
+
+        assertNotNull(result)
+        assertEquals("ios", result.platform)
+        assertEquals("damus://note/<bech32>", result.uri)
+        assertEquals("naddr", result.entityType)
+    }
+
+    @Test
+    fun rejectsTagWithOnlyOneElement() {
+        val tag = arrayOf("web")
+        assertNull(PlatformLinkTag.parse(tag))
+    }
+
+    @Test
+    fun rejectsUnknownPlatform() {
+        val tag = arrayOf("windows", "https://example.com", "note")
+        assertNull(PlatformLinkTag.parse(tag))
+    }
+
+    @Test
+    fun roundTripPreservesValues() {
+        val original = PlatformLinkTag("web", "https://example.com/e/<bech32>", "nevent")
+        val tagArray = original.toTagArray()
+        val parsed = PlatformLinkTag.parse(tagArray)
+
+        assertNotNull(parsed)
+        assertEquals(original.platform, parsed.platform)
+        assertEquals(original.uri, parsed.uri)
+        assertEquals(original.entityType, parsed.entityType)
+    }
+
+    @Test
+    fun roundTripWithoutEntityType() {
+        val original = PlatformLinkTag("android", "amethyst://open/<bech32>", null)
+        val tagArray = original.toTagArray()
+        val parsed = PlatformLinkTag.parse(tagArray)
+
+        // Without entityType, tag only has 2 elements, so match requires has(2) which means 3 elements
+        // This is expected behavior per NIP-89 spec (entityType is specified)
+        assertNull(parsed)
+    }
+}