Merge remote-tracking branch 'origin/main' into claude/thin-material-icons-9SFWk

# Conflicts:
#	desktopApp/src/jvmMain/kotlin/com/vitorpamplona/amethyst/desktop/Main.kt
This commit is contained in:
Claude
2026-04-23 22:12:15 +00:00
54 changed files with 1932 additions and 166 deletions
+12 -1
View File
@@ -104,9 +104,15 @@ Wire-up checklist:
4. Extend `printUsage()` in `Main.kt`.
5. Add the row to `cli/README.md`'s command table.
6. Update `cli/ROADMAP.md` — move the row from 🆕 / 📦 to ✅.
7. If the verb changes observable wire behaviour (a new event kind,
a new relay-routing rule, a new JSON discriminator), add a case
in the appropriate harness under `cli/tests/``cli/tests/marmot/`
for MLS flows, `cli/tests/dm/` for NIP-17, or a new sibling suite
if it's neither.
If you change output shape: note it in the commit message, bump the
example in `README.md`, update any interop fixtures.
example in `README.md`, update any interop fixtures under
`cli/tests/`.
## Where things live
@@ -116,6 +122,11 @@ cli/
├── DEVELOPMENT.md # touch-the-code: architecture, conventions, testing
├── ROADMAP.md # parity matrix + ordered milestones
├── plans/ # dated design docs (use for new subsystems)
├── tests/ # end-to-end shell harnesses against a local relay
│ ├── lib.sh # shared logging + result tracking
│ ├── headless/ # shared amy wrappers + assertions
│ ├── marmot/ # MLS group-messaging interop (vs whitenoise-rs)
│ └── dm/ # NIP-17 DM interop (two amy clients)
└── src/main/kotlin/…/cli/
├── Main.kt # argv dispatch
├── Args.kt # flag parser
@@ -20,6 +20,7 @@
*/
package com.vitorpamplona.amethyst.service.relayClient.reqCommand.account.nip59GiftWraps
import com.vitorpamplona.amethyst.commons.relayClient.nip17Dm.filterGiftWrapsToPubkey
import com.vitorpamplona.amethyst.model.User
import com.vitorpamplona.amethyst.service.relayClient.eoseManagers.PerUserEoseManager
import com.vitorpamplona.amethyst.service.relayClient.reqCommand.account.AccountQueryState
@@ -231,19 +231,28 @@ fun NonClickableUserPictures(
room: ChatroomKey,
size: Dp,
accountViewModel: AccountViewModel,
) {
NonClickableUserPictures(room.users.toList(), size, accountViewModel)
}
@Composable
fun NonClickableUserPictures(
userHexList: List<HexKey>,
size: Dp,
accountViewModel: AccountViewModel,
) {
Box(Modifier.size(size), contentAlignment = Alignment.TopEnd) {
when (room.users.size) {
when (userHexList.size) {
0 -> {}
1 -> {
LoadUser(baseUserHex = room.users.first(), accountViewModel) {
LoadUser(baseUserHex = userHexList.first(), accountViewModel) {
it?.let { BaseUserPicture(it, size, accountViewModel, outerModifier = Modifier) }
}
}
2 -> {
val userList = room.users.toList()
val userList = userHexList
LoadUser(baseUserHex = userList[0], accountViewModel) {
it?.let {
@@ -268,7 +277,7 @@ fun NonClickableUserPictures(
}
3 -> {
val userList = room.users.toList()
val userList = userHexList
LoadUser(baseUserHex = userList[0], accountViewModel) {
it?.let {
@@ -303,7 +312,7 @@ fun NonClickableUserPictures(
}
else -> {
val userList = room.users.toList()
val userList = userHexList
LoadUser(baseUserHex = userList[0], accountViewModel) {
it?.let {
@@ -21,7 +21,9 @@
package com.vitorpamplona.amethyst.ui.screen.loggedIn.chats.marmotGroup
import androidx.compose.foundation.clickable
import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.padding
import androidx.compose.material3.ExperimentalMaterial3Api
import androidx.compose.material3.Icon
@@ -32,14 +34,18 @@ import androidx.compose.material3.TopAppBar
import androidx.compose.runtime.Composable
import androidx.compose.runtime.getValue
import androidx.compose.runtime.remember
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.unit.dp
import androidx.lifecycle.compose.collectAsStateWithLifecycle
import com.vitorpamplona.amethyst.commons.icons.symbols.Icon
import com.vitorpamplona.amethyst.commons.icons.symbols.MaterialSymbols
import com.vitorpamplona.amethyst.ui.layouts.DisappearingScaffold
import com.vitorpamplona.amethyst.ui.navigation.navs.INav
import com.vitorpamplona.amethyst.ui.navigation.routes.Route
import com.vitorpamplona.amethyst.ui.note.NonClickableUserPictures
import com.vitorpamplona.amethyst.ui.screen.loggedIn.AccountViewModel
import com.vitorpamplona.amethyst.ui.screen.loggedIn.chats.privateDM.header.DisplayUserSetAsSubject
import com.vitorpamplona.quartz.nip01Core.core.HexKey
@OptIn(ExperimentalMaterial3Api::class)
@@ -55,6 +61,8 @@ fun MarmotGroupChatScreen(
}
val displayName by chatroom.displayName.collectAsStateWithLifecycle()
val memberCount by chatroom.memberCount.collectAsStateWithLifecycle()
val members by chatroom.members.collectAsStateWithLifecycle()
val memberPubkeys = remember(members) { members.map { it.pubkey } }
DisappearingScaffold(
isInvertedLayout = true,
@@ -69,13 +77,32 @@ fun MarmotGroupChatScreen(
}
},
title = {
Column(
Row(
modifier =
Modifier.clickable {
nav.nav(Route.MarmotGroupInfo(nostrGroupId))
},
verticalAlignment = Alignment.CenterVertically,
horizontalArrangement = Arrangement.spacedBy(8.dp),
) {
Text(displayName ?: "Marmot Group")
if (memberPubkeys.isNotEmpty()) {
NonClickableUserPictures(
userHexList = memberPubkeys,
size = 36.dp,
accountViewModel = accountViewModel,
)
}
Column {
if (!displayName.isNullOrBlank()) {
Text(displayName!!)
} else if (memberPubkeys.isNotEmpty()) {
DisplayUserSetAsSubject(
userList = memberPubkeys,
accountViewModel = accountViewModel,
)
} else {
Text("Marmot Group")
}
if (memberCount > 0) {
Text(
text = "$memberCount members",
@@ -83,6 +110,7 @@ fun MarmotGroupChatScreen(
)
}
}
}
},
actions = {
IconButton(onClick = { nav.nav(Route.MarmotGroupInfo(nostrGroupId)) }) {
@@ -64,7 +64,9 @@ import com.vitorpamplona.amethyst.commons.icons.symbols.MaterialSymbols
import com.vitorpamplona.amethyst.commons.model.marmotGroups.MarmotGroupChatroom
import com.vitorpamplona.amethyst.ui.navigation.navs.INav
import com.vitorpamplona.amethyst.ui.navigation.routes.Route
import com.vitorpamplona.amethyst.ui.note.NonClickableUserPictures
import com.vitorpamplona.amethyst.ui.screen.loggedIn.AccountViewModel
import com.vitorpamplona.amethyst.ui.screen.loggedIn.chats.privateDM.header.DisplayUserSetAsSubject
import com.vitorpamplona.quartz.nip01Core.core.HexKey
@OptIn(ExperimentalMaterial3Api::class)
@@ -178,6 +180,7 @@ fun MarmotGroupListScreen(
MarmotGroupListItem(
groupId = groupId,
chatroom = chatroom,
accountViewModel = accountViewModel,
onClick = {
nav.nav(Route.MarmotGroupChat(groupId))
},
@@ -212,10 +215,13 @@ private fun loadGroupList(
fun MarmotGroupListItem(
groupId: HexKey,
chatroom: MarmotGroupChatroom,
accountViewModel: AccountViewModel,
onClick: () -> Unit,
) {
val displayName by chatroom.displayName.collectAsStateWithLifecycle()
val unread by chatroom.unreadCount.collectAsStateWithLifecycle()
val members by chatroom.members.collectAsStateWithLifecycle()
val memberPubkeys = remember(members) { members.map { it.pubkey } }
val newestMessage = chatroom.newestMessage
Row(
@@ -224,17 +230,40 @@ fun MarmotGroupListItem(
.fillMaxWidth()
.clickable(onClick = onClick)
.padding(horizontal = 16.dp, vertical = 12.dp),
horizontalArrangement = Arrangement.SpaceBetween,
horizontalArrangement = Arrangement.spacedBy(12.dp),
verticalAlignment = Alignment.CenterVertically,
) {
if (memberPubkeys.isNotEmpty()) {
NonClickableUserPictures(
userHexList = memberPubkeys,
size = 55.dp,
accountViewModel = accountViewModel,
)
}
Column(modifier = Modifier.weight(1f)) {
if (!displayName.isNullOrBlank()) {
Text(
text = displayName ?: "Group ${groupId.take(8)}...",
text = displayName!!,
style = MaterialTheme.typography.titleSmall,
fontWeight = if (unread > 0) FontWeight.Bold else FontWeight.Normal,
maxLines = 1,
overflow = TextOverflow.Ellipsis,
)
} else if (memberPubkeys.isNotEmpty()) {
DisplayUserSetAsSubject(
userList = memberPubkeys,
accountViewModel = accountViewModel,
fontWeight = if (unread > 0) FontWeight.Bold else FontWeight.Normal,
)
} else {
Text(
text = "Group ${groupId.take(8)}...",
style = MaterialTheme.typography.titleSmall,
fontWeight = if (unread > 0) FontWeight.Bold else FontWeight.Normal,
maxLines = 1,
overflow = TextOverflow.Ellipsis,
)
}
if (newestMessage != null) {
Text(
text = newestMessage.event?.content ?: "",
@@ -69,7 +69,15 @@ fun DisplayUserSetAsSubject(
fontWeight: FontWeight = FontWeight.Bold,
) {
val userList = remember(room) { room.users.toList() }
DisplayUserSetAsSubject(userList, accountViewModel, fontWeight)
}
@Composable
fun DisplayUserSetAsSubject(
userList: List<HexKey>,
accountViewModel: AccountViewModel,
fontWeight: FontWeight = FontWeight.Bold,
) {
if (userList.size == 1) {
// Regular Design
Row {
@@ -216,7 +216,6 @@ private fun hasNonDefaultFilters(
@OptIn(ExperimentalMaterial3Api::class)
@Composable
@Suppress("AssignedValueIsNeverRead")
private fun SearchFilterRow(searchBarViewModel: SearchBarViewModel) {
val currentScope by searchBarViewModel.scope.collectAsStateWithLifecycle()
val currentSource by searchBarViewModel.source.collectAsStateWithLifecycle()
@@ -2164,4 +2164,66 @@
<string name="emoji_private_badge">Soukromé emoji</string>
<string name="emoji_public_explainer">Veřejná emoji jsou viditelná pro všechny a objeví se ve vaší nabídce reakcí a v automatickém doplňování \":\", když je tento balíček ve vašem seznamu emoji.</string>
<string name="emoji_private_explainer">Soukromá emoji jsou šifrovaně uložena na relayích a viditelná pouze pro vás. Objeví se ve vaší nabídce reakcí a v automatickém doplňování \":\" stejně jako veřejná.</string>
<string name="always_on_notif_channel_description">Udržuje připojení k vašim inbox relayím aktivní pro oznámení v reálném čase</string>
<string name="always_on_notif_connected">Připojeno k %1$d inbox relayím</string>
<string name="always_on_notif_connecting">Připojování k inbox relayím\u2026</string>
<string name="always_on_notif_setting_description">Udržuje trvalé připojení k vašim inbox relayím pro okamžité doručování oznámení. Zobrazuje průběžné oznámení. Spotřebovává více baterie, ale zajišťuje, že nezmeškáte žádnou zprávu.</string>
<string name="always_on_notif_setting_title">Služba trvalých oznámení</string>
<string name="always_on_notif_stop">Pozastavit</string>
<string name="always_on_notif_title">Amethyst oznámení aktivní</string>
<string name="audio_room_audience">Publikum</string>
<string name="audio_room_lower_hand">Dát ruku dolů</string>
<string name="audio_room_raise_hand">Přihlásit se</string>
<string name="audio_room_stage">Pódium</string>
<string name="audio_rooms">Audio místnosti</string>
<string name="badge_image_placeholder">https://example.com/badge.png</string>
<string name="badge_thumb_placeholder">https://example.com/badge-thumb.png</string>
<string name="battery_optimization_description">Android může omezit připojení k relayím na pozadí. Vypněte optimalizaci baterie pro Amethyst, aby byla oznámení spolehlivá.</string>
<string name="battery_optimization_fix_now">Opravit</string>
<string name="battery_optimization_title">Optimalizace baterie aktivní</string>
<string name="bottom_bar_settings">Spodní navigační lišta</string>
<string name="bottom_bar_settings_available">Dostupné</string>
<string name="bottom_bar_settings_description">Přetažením změníte pořadí. Přepnutím položku přidáte nebo odeberete ze spodní lišty. S nulovým počtem položek bude lišta skryta.</string>
<string name="bottom_bar_settings_reorder">Změnit pořadí</string>
<string name="drawer_section_create">Vytvořit</string>
<string name="drawer_section_feeds">Kanály</string>
<string name="drawer_section_navigate">Navigace</string>
<string name="drawer_section_system">Systém</string>
<string name="drawer_section_you">Vy</string>
<string name="emoji_sets">Emoji</string>
<string name="follow_packs">Seznamy sledování</string>
<string name="live_streams">Živé vysílání</string>
<string name="public_chats">Veřejné chaty</string>
<string name="search_filters_open">Filtry</string>
<string name="search_filters_reset">Obnovit</string>
<string name="search_filters_section_sort">Seřadit podle</string>
<string name="search_filters_section_source">Zdroj</string>
<string name="search_filters_title">Filtry</string>
<string name="search_follows_only">Pouze sledovaní</string>
<string name="search_scope_all">Vše</string>
<string name="search_scope_notes">Poznámky</string>
<string name="search_scope_people">Lidé</string>
<string name="search_sort_newest">Nejnovější</string>
<string name="search_sort_oldest">Nejstarší</string>
<string name="search_sort_popular">Populární</string>
<string name="search_sort_relevance">Relevance</string>
<string name="search_source_local">Lokální</string>
<string name="search_source_relays">Relaye</string>
<string name="video_player_settings">Tlačítka přehrávače videa</string>
<string name="video_player_settings_description">Zvolte, která tlačítka se objeví na přehrávači videa a která budou v nabídce přetečení. Přetažením změníte pořadí.</string>
<string name="video_player_settings_reorder">Změnit pořadí</string>
<string name="video_player_settings_location_top_bar">Horní lišta</string>
<string name="video_player_settings_location_overflow">Nabídka přetečení</string>
<string name="video_player_settings_action_fullscreen">Celá obrazovka</string>
<string name="video_player_settings_action_fullscreen_description">Otevřít video v zobrazení na celou obrazovku</string>
<string name="video_player_settings_action_mute">Ztlumit</string>
<string name="video_player_settings_action_mute_description">Zapnout nebo vypnout zvuk</string>
<string name="video_player_settings_action_quality">Kvalita videa</string>
<string name="video_player_settings_action_quality_description">Vybrat rozlišení pro HLS videa (skryto pro jiná videa)</string>
<string name="video_player_settings_action_share">Sdílet nebo uložit</string>
<string name="video_player_settings_action_share_description">Sdílet odkaz na video externě</string>
<string name="video_player_settings_action_download">Uložit do telefonu</string>
<string name="video_player_settings_action_download_description">Stáhnout video do zařízení (skryto u živých vysílání)</string>
<string name="video_player_settings_action_pip">Obraz v obraze</string>
<string name="video_player_settings_action_pip_description">Přehrávat video v plovoucím okně (skryto, pokud není podporováno)</string>
</resources>
@@ -2167,4 +2167,68 @@ anz der Bedingungen ist erforderlich</string>
<string name="emoji_private_badge">Privates Emoji</string>
<string name="emoji_public_explainer">Öffentliche Emojis sind für alle sichtbar und erscheinen in deinem Reaktionsmenü und in der \":\"-Autovervollständigungsauswahl, wenn dieses Paket in deiner Emoji-Liste ist.</string>
<string name="emoji_private_explainer">Private Emojis werden verschlüsselt auf Relays gespeichert und sind nur für dich sichtbar. Sie erscheinen in deinem Reaktionsmenü und in der \":\"-Autovervollständigung wie öffentliche.</string>
<string name="always_on_notif_channel_description">Hält Verbindungen zu deinen Inbox-Relays aktiv für Echtzeit-Benachrichtigungen</string>
<string name="always_on_notif_connected">Mit %1$d Inbox-Relays verbunden</string>
<string name="always_on_notif_connecting">Verbinde mit Inbox-Relays\u2026</string>
<string name="always_on_notif_setting_description">Hält eine dauerhafte Verbindung zu deinen Inbox-Relays für sofortige Benachrichtigungen aufrecht. Zeigt eine fortlaufende Benachrichtigung an. Verbraucht mehr Akku, stellt aber sicher, dass du keine Nachricht verpasst.</string>
<string name="always_on_notif_setting_title">Dauerhafter Benachrichtigungsdienst</string>
<string name="always_on_notif_stop">Pausieren</string>
<string name="always_on_notif_title">Amethyst-Benachrichtigungen aktiv</string>
<string name="audio_room_audience">Publikum</string>
<string name="audio_room_lower_hand">Hand senken</string>
<string name="audio_room_raise_hand">Hand heben</string>
<string name="audio_room_stage">Bühne</string>
<string name="audio_rooms">Audioräume</string>
<string name="badge_image_placeholder">https://example.com/badge.png</string>
<string name="badge_thumb_placeholder">https://example.com/badge-thumb.png</string>
<string name="battery_optimization_description">Android kann Relay-Verbindungen im Hintergrund einschränken. Deaktiviere die Akkuoptimierung für Amethyst, um zuverlässige Benachrichtigungen zu gewährleisten.</string>
<string name="battery_optimization_fix_now">Jetzt beheben</string>
<string name="battery_optimization_title">Akkuoptimierung aktiv</string>
<string name="bottom_bar_settings">Untere Navigationsleiste</string>
<string name="bottom_bar_settings_available">Verfügbar</string>
<string name="bottom_bar_settings_description">Zum Umordnen ziehen. Zum Hinzufügen oder Entfernen eines Elements aus der unteren Leiste umschalten. Mit null Elementen wird die untere Leiste ausgeblendet.</string>
<string name="bottom_bar_settings_reorder">Umordnen</string>
<string name="drawer_section_create">Erstellen</string>
<string name="drawer_section_feeds">Feeds</string>
<string name="drawer_section_navigate">Navigieren</string>
<string name="drawer_section_system">System</string>
<string name="drawer_section_you">Du</string>
<string name="emoji_sets">Emojis</string>
<string name="follow_packs">Follow-Pakete</string>
<string name="live_streams">Live-Streams</string>
<string name="public_chats">Öffentliche Chats</string>
<string name="search_filters_open">Filter</string>
<string name="search_filters_reset">Zurücksetzen</string>
<string name="search_filters_section_sort">Sortieren nach</string>
<string name="search_filters_section_source">Quelle</string>
<string name="search_filters_title">Filter</string>
<string name="search_follows_only">Nur Gefolgte</string>
<string name="search_scope_all">Alle</string>
<string name="search_scope_notes">Notizen</string>
<string name="search_scope_people">Personen</string>
<string name="search_sort_newest">Neueste</string>
<string name="search_sort_oldest">Älteste</string>
<string name="search_sort_popular">Beliebte</string>
<string name="search_sort_relevance">Relevanz</string>
<string name="search_source_local">Lokal</string>
<string name="search_source_relays">Relays</string>
<string name="video_player_settings">Videoplayer-Schaltflächen</string>
<string name="video_player_settings_description">Wähle, welche Schaltflächen im Videoplayer erscheinen und welche im Überlaufmenü liegen. Zum Umordnen ziehen.</string>
<string name="video_player_settings_reorder">Umordnen</string>
<string name="video_player_settings_location_top_bar">Obere Leiste</string>
<string name="video_player_settings_location_overflow">Überlaufmenü</string>
<string name="video_player_settings_action_fullscreen">Vollbild</string>
<string name="video_player_settings_action_fullscreen_description">Video in einer Vollbildansicht öffnen</string>
<string name="video_player_settings_action_mute">Stumm</string>
<string name="video_player_settings_action_mute_description">Ton ein- oder ausschalten</string>
<string name="video_player_settings_action_quality">Videoqualität</string>
<string name="video_player_settings_action_quality_description">Auflösung für HLS-Videos wählen (bei Nicht-HLS-Videos ausgeblendet)</string>
<string name="video_player_settings_action_share">Teilen oder speichern</string>
<string name="video_player_settings_action_share_description">Den Videolink extern teilen</string>
<string name="video_player_settings_action_download">Auf Telefon speichern</string>
<string name="video_player_settings_action_download_description">Video auf dein Gerät herunterladen (bei Live-Streams ausgeblendet)</string>
<string name="video_player_settings_action_pip">Bild-in-Bild</string>
<string name="video_player_settings_action_pip_description">Video in einem schwebenden Fenster abspielen (ausgeblendet, wenn nicht unterstützt)</string>
<string name="badge_name_label">Name</string>
<string name="new_community_relays_section">Relays</string>
</resources>
@@ -2161,4 +2161,69 @@
<string name="emoji_private_badge">Emoji privado</string>
<string name="emoji_public_explainer">Emojis públicos são visíveis para todos e aparecem no seu menu de reações e no seletor de autocompletar \":\" quando este pacote está na sua lista de emojis.</string>
<string name="emoji_private_explainer">Emojis privados são armazenados criptografados em relays e visíveis apenas para você. Eles aparecem no seu menu de reações e no autocompletar \":\" assim como os públicos.</string>
<string name="always_on_notif_channel_description">Mantém as conexões com seus relays de caixa de entrada ativas para notificações em tempo real</string>
<string name="always_on_notif_connected">Conectado a %1$d relays de caixa de entrada</string>
<string name="always_on_notif_connecting">Conectando aos relays de caixa de entrada\u2026</string>
<string name="always_on_notif_setting_description">Mantém uma conexão persistente com seus relays de caixa de entrada para entrega instantânea de notificações. Mostra uma notificação contínua. Usa mais bateria, mas garante que você nunca perca uma mensagem.</string>
<string name="always_on_notif_setting_title">Serviço de notificações sempre ativo</string>
<string name="always_on_notif_stop">Pausar</string>
<string name="always_on_notif_title">Notificações do Amethyst ativas</string>
<string name="audio_room_audience">Plateia</string>
<string name="audio_room_lower_hand">Abaixar mão</string>
<string name="audio_room_raise_hand">Levantar mão</string>
<string name="audio_room_stage">Palco</string>
<string name="audio_rooms">Salas de áudio</string>
<string name="badge_image_placeholder">https://example.com/badge.png</string>
<string name="badge_thumb_placeholder">https://example.com/badge-thumb.png</string>
<string name="battery_optimization_description">O Android pode restringir conexões de relay em segundo plano. Desative a otimização de bateria para o Amethyst para garantir notificações confiáveis.</string>
<string name="battery_optimization_fix_now">Corrigir agora</string>
<string name="battery_optimization_title">Otimização de bateria ativa</string>
<string name="bottom_bar_settings">Barra de navegação inferior</string>
<string name="bottom_bar_settings_available">Disponíveis</string>
<string name="bottom_bar_settings_description">Arraste para reordenar. Alterne para adicionar ou remover um item da barra inferior. Com zero itens, a barra inferior fica oculta.</string>
<string name="bottom_bar_settings_reorder">Reordenar</string>
<string name="drawer_section_create">Criar</string>
<string name="drawer_section_feeds">Feeds</string>
<string name="drawer_section_navigate">Navegar</string>
<string name="drawer_section_system">Sistema</string>
<string name="drawer_section_you">Você</string>
<string name="emoji_sets">Emojis</string>
<string name="follow_packs">Pacotes de seguidos</string>
<string name="live_streams">Transmissões ao vivo</string>
<string name="public_chats">Chats públicos</string>
<string name="search_filters_open">Filtros</string>
<string name="search_filters_reset">Redefinir</string>
<string name="search_filters_section_sort">Ordenar por</string>
<string name="search_filters_section_source">Fonte</string>
<string name="search_filters_title">Filtros</string>
<string name="search_follows_only">Apenas seguidos</string>
<string name="search_scope_all">Tudo</string>
<string name="search_scope_notes">Notas</string>
<string name="search_scope_people">Pessoas</string>
<string name="search_sort_newest">Mais recentes</string>
<string name="search_sort_oldest">Mais antigos</string>
<string name="search_sort_popular">Populares</string>
<string name="search_sort_relevance">Relevância</string>
<string name="search_source_local">Local</string>
<string name="search_source_relays">Relays</string>
<string name="video_player_settings">Botões do reprodutor de vídeo</string>
<string name="video_player_settings_description">Escolha quais botões aparecem no reprodutor de vídeo e quais ficam no menu de transbordo. Arraste para reordenar.</string>
<string name="video_player_settings_reorder">Reordenar</string>
<string name="video_player_settings_location_top_bar">Barra superior</string>
<string name="video_player_settings_location_overflow">Menu de transbordo</string>
<string name="video_player_settings_action_fullscreen">Tela cheia</string>
<string name="video_player_settings_action_fullscreen_description">Abrir o vídeo em modo tela cheia</string>
<string name="video_player_settings_action_mute">Silenciar</string>
<string name="video_player_settings_action_mute_description">Ativar ou desativar o áudio</string>
<string name="video_player_settings_action_quality">Qualidade do vídeo</string>
<string name="video_player_settings_action_quality_description">Escolher uma resolução para vídeos HLS (oculto em vídeos não-HLS)</string>
<string name="video_player_settings_action_share">Compartilhar ou salvar</string>
<string name="video_player_settings_action_share_description">Compartilhar o link do vídeo externamente</string>
<string name="video_player_settings_action_download">Salvar no telefone</string>
<string name="video_player_settings_action_download_description">Baixar o vídeo para o dispositivo (oculto em transmissões ao vivo)</string>
<string name="video_player_settings_action_pip">Picture-in-Picture</string>
<string name="video_player_settings_action_pip_description">Reproduzir o vídeo em uma janela flutuante (oculto se não suportado)</string>
<string name="emoji_pack_count">%1$d emojis</string>
<string name="interest_set_hashtag_count">%1$d hashtag(s)</string>
<string name="new_community_relays_section">Relays</string>
</resources>
@@ -2162,4 +2162,67 @@
<string name="emoji_private_badge">Privat emoji</string>
<string name="emoji_public_explainer">Offentliga emojis är synliga för alla och visas i din reaktionsmeny och i \":\"-autokompletteringen när detta paket finns i din emoji-lista.</string>
<string name="emoji_private_explainer">Privata emojis lagras krypterade på relän och är endast synliga för dig. De visas i din reaktionsmeny och i autokomplettering med \":\" precis som offentliga.</string>
<string name="always_on_notif_channel_description">Håller anslutningarna till dina inbox-relän aktiva för realtidsnotifieringar</string>
<string name="always_on_notif_connected">Ansluten till %1$d inbox-relän</string>
<string name="always_on_notif_connecting">Ansluter till inbox-relän\u2026</string>
<string name="always_on_notif_setting_description">Upprätthåller en konstant anslutning till dina inbox-relän för omedelbar leverans av notifieringar. Visar en pågående notifiering. Använder mer batteri men säkerställer att du aldrig missar ett meddelande.</string>
<string name="always_on_notif_setting_title">Alltid på-notifieringstjänst</string>
<string name="always_on_notif_stop">Pausa</string>
<string name="always_on_notif_title">Amethyst-notifieringar aktiva</string>
<string name="audio_room_audience">Publik</string>
<string name="audio_room_lower_hand">Sänk handen</string>
<string name="audio_room_raise_hand">Räck upp handen</string>
<string name="audio_room_stage">Scen</string>
<string name="audio_rooms">Ljudrum</string>
<string name="badge_image_placeholder">https://example.com/badge.png</string>
<string name="badge_thumb_placeholder">https://example.com/badge-thumb.png</string>
<string name="battery_optimization_description">Android kan begränsa reläanslutningar i bakgrunden. Inaktivera batterioptimering för Amethyst för att säkerställa tillförlitliga notifieringar.</string>
<string name="battery_optimization_fix_now">Åtgärda nu</string>
<string name="battery_optimization_title">Batterioptimering aktiv</string>
<string name="bottom_bar_settings">Nedre navigeringsfält</string>
<string name="bottom_bar_settings_available">Tillgängliga</string>
<string name="bottom_bar_settings_description">Dra för att ändra ordning. Växla för att lägga till eller ta bort ett objekt från nedre fältet. Med noll objekt döljs det nedre fältet.</string>
<string name="bottom_bar_settings_reorder">Ändra ordning</string>
<string name="drawer_section_create">Skapa</string>
<string name="drawer_section_feeds">Flöden</string>
<string name="drawer_section_navigate">Navigera</string>
<string name="drawer_section_system">System</string>
<string name="drawer_section_you">Du</string>
<string name="emoji_sets">Emojis</string>
<string name="follow_packs">Följpaket</string>
<string name="live_streams">Livesändningar</string>
<string name="public_chats">Offentliga chattar</string>
<string name="search_filters_open">Filter</string>
<string name="search_filters_reset">Återställ</string>
<string name="search_filters_section_sort">Sortera efter</string>
<string name="search_filters_section_source">Källa</string>
<string name="search_filters_title">Filter</string>
<string name="search_follows_only">Endast följda</string>
<string name="search_scope_all">Alla</string>
<string name="search_scope_notes">Anteckningar</string>
<string name="search_scope_people">Personer</string>
<string name="search_sort_newest">Nyaste</string>
<string name="search_sort_oldest">Äldsta</string>
<string name="search_sort_popular">Populära</string>
<string name="search_sort_relevance">Relevans</string>
<string name="search_source_local">Lokalt</string>
<string name="search_source_relays">Relän</string>
<string name="video_player_settings">Videospelarens knappar</string>
<string name="video_player_settings_description">Välj vilka knappar som visas på videospelaren och vilka som finns i överflödsmenyn. Dra för att ändra ordning.</string>
<string name="video_player_settings_reorder">Ändra ordning</string>
<string name="video_player_settings_location_top_bar">Övre fält</string>
<string name="video_player_settings_location_overflow">Överflödsmeny</string>
<string name="video_player_settings_action_fullscreen">Helskärm</string>
<string name="video_player_settings_action_fullscreen_description">Öppna videon i helskärmsläge</string>
<string name="video_player_settings_action_mute">Tyst</string>
<string name="video_player_settings_action_mute_description">Slå på eller av ljudet</string>
<string name="video_player_settings_action_quality">Videokvalitet</string>
<string name="video_player_settings_action_quality_description">Välj en upplösning för HLS-videor (dolt för icke-HLS-videor)</string>
<string name="video_player_settings_action_share">Dela eller spara</string>
<string name="video_player_settings_action_share_description">Dela videolänken externt</string>
<string name="video_player_settings_action_download">Spara på telefonen</string>
<string name="video_player_settings_action_download_description">Ladda ner videon till enheten (dolt vid livesändningar)</string>
<string name="video_player_settings_action_pip">Bild-i-bild</string>
<string name="video_player_settings_action_pip_description">Spela upp videon i ett flytande fönster (dolt om det inte stöds)</string>
<string name="emoji_pack_count">%1$d emojis</string>
</resources>
+7 -2
View File
@@ -197,8 +197,8 @@ Amy-specific layer still needs its own coverage:
| Error / exit-code contract (bad args → 2, await timeout → 124, runtime → 1) | Table-driven tests invoking `main(argv)` with captured stdout/stderr. |
| JSON output shape (each command's keys and types) | Snapshot tests: run a command against a throwaway data-dir, assert the JSON matches a golden file. |
| File layout on disk (`identity.json`, `relays.json`, `groups/*.mls`, `keypackages.bundle`) | Structural assertions after a command sequence. |
| Round-trip between two data-dirs on a local relay | End-to-end shell scripts under `cli/src/test/resources/scripts/`. Spin up `nostr-rs-relay`, run Alice + Bob, assert await verbs resolve. |
| Interop with other clients | External harness consumes Amy as a binary; out of scope here but the JSON contract is what keeps it stable. |
| Round-trip between two data-dirs on a local relay | End-to-end shell harnesses under `cli/tests/`. Each harness spins up a local `nostr-rs-relay`, bootstraps two or more fresh identities in their own `--data-dir`s, and drives a scenario via `amy` (+ `wn` for Marmot interop against whitenoise-rs). Today there are two suites: `cli/tests/marmot/` (13 MLS scenarios vs whitenoise-rs) and `cli/tests/dm/` (NIP-17 DM round-trips between two `amy` clients). |
| Interop with other clients | Covered by `cli/tests/marmot/marmot-interop-headless.sh` (drives Amy against whitenoise-rs `wn`/`wnd`). Add new scenarios there or start a new sibling under `cli/tests/`. |
**What not to test here:** event signing, filter assembly, MLS
correctness, NIP-44 encryption. Those belong in `quartz`/`commons`.
@@ -207,6 +207,11 @@ If an Amy bug can only be caught here, it's a contract violation
**Interop-test script template:**
The canonical examples live under `cli/tests/` — read
[`cli/tests/README.md`](./tests/README.md) for the layout, then
crib from `cli/tests/dm/tests-dm.sh` or `cli/tests/marmot/tests-create.sh`.
At the byte-banging level, a minimal round-trip looks like:
```bash
set -euo pipefail
TMP=$(mktemp -d)
+9 -1
View File
@@ -98,7 +98,10 @@ GID=$(amy --data-dir ./alice marmot group create --name "Test" | jq -r .group_id
```
For an interop-test script template, see
[DEVELOPMENT.md § Testing](./DEVELOPMENT.md#testing).
[DEVELOPMENT.md § Testing](./DEVELOPMENT.md#testing). The runnable
harnesses live under [`cli/tests/`](./tests/README.md) —
`cli/tests/marmot/` for MLS group messaging vs whitenoise-rs,
`cli/tests/dm/` for NIP-17 DMs between two `amy` clients.
---
@@ -137,6 +140,11 @@ Run `amy --help` for the canonical list. As of today:
| `marmot await message GID --match TEXT` | Block until a message containing `TEXT` lands. |
| `marmot await rename GID --name NAME` | Block until GID's name matches. |
| `marmot await epoch GID --min N` | Block until GID's MLS epoch is ≥ N. |
| `dm send RECIPIENT TEXT [--allow-fallback]` | Send a NIP-17 gift-wrapped text DM (kind:14 inside kind:1059). Default delivers only to the recipient's kind:10050 (per NIP-17); pass `--allow-fallback` to fall back to kind:10002 read marker → bootstrap pool. |
| `dm send-file RECIPIENT --file PATH --server URL [--mime-type M] [--allow-fallback]` | Encrypt the local file with a fresh AES-GCM cipher, upload the ciphertext to the Blossom server, then publish a kind:15 NIP-17 file message referencing the returned URL. The auto-detected hash, size, dimensions, and blurhash from the upload are folded into the event. The response also surfaces the encryption key + nonce so the same blob can be re-shared without re-uploading. |
| `dm send-file RECIPIENT URL --key HEX --nonce HEX [--mime-type M] [--hash H] [--original-hash H] [--size N] [--dim WxH] [--blurhash S] [--allow-fallback]` | Reference-mode variant: the file is already uploaded; `--key`/`--nonce` carry the AES-GCM material that recipients use to decrypt the bytes at `URL`. Useful when the upload happened elsewhere or to re-publish a previously-uploaded blob. |
| `dm list [--peer NPUB] [--since TS] [--limit N] [--timeout SECS]` | Drain and decrypt gift wraps on our inbox relays. Returns kind:14 (text) and kind:15 (file) messages with a `type` discriminator. With neither `--peer` nor `--since` the gift-wrap cursor in `state.json` is advanced to the newest message seen. |
| `dm await --peer NPUB --match TEXT [--timeout SECS]` | Block until a DM from NPUB containing TEXT arrives (matches text content for kind:14, URL for kind:15). Timeout exits 124. |
All `await` verbs accept `--timeout SECS` (default 30). Timeout exits 124
so scripts can distinguish "condition never happened" from "the command
+7 -2
View File
@@ -52,7 +52,7 @@ Status legend: ✅ shipped · 📦 logic lives in `commons/`, needs a command ·
| NIP-01 feed read (`amy feed home`, `amy feed hashtag #X`, `amy feed profile NPUB`) | 🆕 | Extract `FeedFilter` usage from `amethyst/ui/dal/` into `commons/` entry points. |
| NIP-02 follow list add / remove / list | 🆕 | Logic in `amethyst/model/nip02FollowLists/`. |
| NIP-09 event deletion | 🆕 | Builder exists in quartz. |
| NIP-17 DMs send / list / read | 🆕 | Gift-wrap path is already in `commons/` via Marmot — generalise. |
| NIP-17 DMs send / list / await | | `DmCommands` — reuses Quartz `NIP17Factory` + `RecipientRelayFetcher`; filter extracted to `commons/relayClient/nip17Dm/`. Plan: [`cli/plans/2026-04-23-nip17-dm.md`](./plans/2026-04-23-nip17-dm.md). |
| NIP-18 reposts / quotes | 🆕 | |
| NIP-25 reactions | 🆕 | |
| NIP-51 lists (bookmarks, mute, follow sets) | 🆕 | `amethyst/model/nip51Lists/` |
@@ -94,7 +94,12 @@ move anything, re-audit — you're probably duplicating logic.
7. **`amy zap send|verify`** (NIP-57).
8. **Distribution** — Homebrew + Scoop + `.deb` in the same release
pipeline as desktop. Plan: `cli/plans/2026-04-21-cli-distribution.md`.
9. **Test suite** — end-to-end against a local relay.
9. **Test suite** — end-to-end against a local relay. Marmot interop is
covered by `cli/tests/marmot/marmot-interop-headless.sh`; NIP-17 DM
interop between two `amy` clients is covered by
`cli/tests/dm/dm-interop-headless.sh` (text + file + strict 10050 +
fallback + cursor-advance). Neither runs in CI yet (both need Rust +
~3 min cold relay build).
10. **Everything else in the matrix.**
---
+252
View File
@@ -0,0 +1,252 @@
# NIP-17 DMs in `amy`
**Status:** plan · **Date:** 2026-04-23 · **Roadmap row:**
`cli/ROADMAP.md:55` ("NIP-17 DMs send / list / read") · **Order:**
step 5 in `cli/ROADMAP.md:91`.
Adds three verbs:
```
amy dm send <recipient> <text> [--peer <npub>...]
amy dm list [--peer <npub>] [--since <ts>] [--limit N] [--timeout SECS]
amy dm await --peer <npub> --match <text> [--timeout SECS]
```
`<recipient>` accepts everything `Context.requireUserHex` does:
`npub`, `nprofile`, 64-hex, `name@domain.tld`. `--peer` may repeat
on `send` to start a multi-recipient chat (NIP-17 supports group
DMs); on `list`/`await` it filters by counter-party.
---
## Guiding principles
1. **Thin assembly only.** Every protocol piece — sealing, wrapping,
NIP-44 — already lives in `quartz/`. The CLI just orchestrates.
2. **One JSON line out, snake_case keys, exit codes 0/1/2/124.**
3. **Reuse Marmot's gift-wrap plumbing** where it already exists in
`Context` (cursor, drain, publish-and-confirm).
4. **No business logic in `cli/`.** The single piece of Android-side
code we depend on (`filterGiftWrapsToPubkey`) is extracted into
`commons/` first, in its own commit.
---
## API surface we reuse (no changes needed)
| Concern | Class | File |
|---|---|---|
| Build `kind:14` chat message template | `ChatMessageEvent.build(msg, to, …)` | `quartz/.../nip17Dm/messages/ChatMessageEvent.kt:51` |
| Sign + seal + wrap (one wrap per recipient incl. self) | `NIP17Factory().createMessageNIP17(template, signer)` | `quartz/.../nip17Dm/NIP17Factory.kt:37` |
| `GiftWrapEvent.create / unwrapOrNull / recipientPubKey` | `GiftWrapEvent` (kind 1059) | `quartz/.../nip59Giftwrap/wraps/GiftWrapEvent.kt` |
| Inner seal layer (kind 13) | `SealedRumorEvent` | `quartz/.../nip59Giftwrap/seals/SealedRumorEvent.kt` |
| NIP-44 v2 encrypt/decrypt (called from wrap/seal) | `Nip44` singleton | `quartz/.../nip44Encryption/Nip44.kt` |
| Resolve recipient relay lists (10050 / 10051 / 10002) | `RecipientRelayFetcher.fetchRelayLists` | `quartz/.../marmot/RecipientRelayFetcher.kt:80` |
| Publish + per-relay ACK | `Context.publish(event, relays)` | `cli/.../Context.kt:154` |
| Drain a subscription until EOSE/timeout | `Context.drain(filters, timeoutMs)` | `cli/.../Context.kt:168` |
| Resolve identifiers | `Context.requireUserHex(input)` | `cli/.../Context.kt:117` |
| In-memory signer (NIP-44 ops included) | `NostrSignerInternal` (`Context.signer`) | `cli/.../Context.kt:68` |
Everything above is already on the JVM classpath of the `cli` module.
---
## Extraction matrix
| Piece | Status | Current | Target | Notes |
|---|---|---|---|---|
| `NIP17Factory`, `GiftWrapEvent`, `SealedRumorEvent`, `Nip44`, `ChatMessageEvent` | ✅ Reuse | `quartz/` | — | Pure protocol; CLI calls directly. |
| `RecipientRelayFetcher.fetchRelayLists` | ✅ Reuse | `quartz/.../marmot/` | — | Already used by `AwaitCommands.awaitKeyPackage`; same call shape. |
| `filterGiftWrapsToPubkey` | 📦 Extract | `amethyst/.../service/relayClient/reqCommand/account/nip59GiftWraps/FilterGiftWrapsToPubkey.kt:31` | `commons/.../relayClient/nip17Dm/FilterGiftWrapsToPubkey.kt` | Pure function, no Android deps. Update Android caller (`AccountGiftWrapsEoseManager.kt:55`) in the same commit. |
| Per-recipient relay routing (kind:10050 → 10002 read → bootstrap) | 🆕 New (in CLI) | inline inside `Account.computeRelayListToBroadcast` (`amethyst/.../model/Account.kt:908`) | `cli/.../commands/DmCommands.kt` (private helper) | Tiny — three-line fallback. Promoting it to commons can wait until a second consumer appears. |
| Send command | 🆕 New | — | `cli/.../commands/DmCommands.kt :: send()` | |
| List command | 🆕 New | — | `cli/.../commands/DmCommands.kt :: list()` | |
| Await command | 🆕 New | — | `cli/.../commands/DmCommands.kt :: await()` | |
| Cursor on disk | ✅ Reuse | `RunState.giftWrapSince` (already used by Marmot `Context.syncIncoming`) | — | Don't fork. DM drain advances the same cursor only when used by `dm list` without `--peer/--since`. |
| Routing in `Main.kt` / `Commands.kt` | 🆕 New | — | `Main.kt` dispatch + `Commands.dm(...)` | One new branch each. |
| Account-bootstrap of own DM inbox (kind:10050) | ⚠️ Not in this plan | `amethyst/.../model/AccountSettings.kt:668` | future `amy relay publish-lists --dm` | Out of scope; we read existing inbox from disk and warn if missing. |
**Rule check (from `amy-expert`):**
- *Rule 1 (thin)*: ✅ — only one new file in `cli/commands/`, < 200 lines.
- *Rule 2 (JSON)*: ✅ — see Output Contract below.
- *Rule 3 (non-interactive)*: ✅ — `--timeout` on the wait verb, no prompts.
- *Rule 4 (data-dir is the world)*: ✅ — relays + signer + cursor all reload from `--data-dir`.
- *Rule 5 (extract first)*: applies once, to `filterGiftWrapsToPubkey` (separate commit).
---
## Send flow (`amy dm send`)
```
parse argv → Context.open → ctx.prepare()
recipients = (positional + --peer) → requireUserHex each
template = ChatMessageEvent.build(text, recipients.map { PTag(it) })
result = NIP17Factory().createMessageNIP17(template, ctx.signer)
─ signs the inner kind:14
─ produces one GiftWrapEvent (1059) per recipient INCLUDING self
for each wrap in result.wraps:
relayList = recipientDmRelays(wrap.recipientPubKey())
─ 1. RecipientRelayFetcher.fetchRelayLists(client, recipient, ctx.bootstrapRelays())
─ 2. .dmInboxOrFallback() (kind:10050 → kind:10002 read marker)
─ 3. fallback to ctx.bootstrapRelays() if both empty
ack = ctx.publish(wrap, relayList)
record { recipient, wrap_id, published_to: ack.true-keys }
emit one JSON line:
{ "event_id": result.msg.id, # inner kind:14 id (stable identity of the message)
"kind": 14,
"recipients": [ {"pubkey":…, "wrap_id":…, "published_to":[…], "relays_tried":[…]} … ] }
```
Notes:
- `result.wraps` already includes a self-addressed wrap; we publish it
the same way as the others so `amy dm list` works as a sanity check
immediately after sending.
- We do NOT add the wrap to any local cache — there is no `LocalCache`
in the CLI; on next `amy dm list` we re-pull from relays.
- If `recipientDmRelays` returns empty for a recipient, exit code `1`
with `{"error":"no_dm_relays","detail":"<npub>"}`. Do not silently drop.
---
## List flow (`amy dm list`)
```
parse argv → Context.open → ctx.prepare()
inbox = ctx.relays.normalized("inbox")
.ifEmpty { ctx.outboxRelays() }
.ifEmpty { ctx.bootstrapRelays() }
since = --since OR (cursor advance mode: state.giftWrapSince OR null)
filters = inbox.flatMap { filterGiftWrapsToPubkey(it, ctx.signer.pubKey, since) }
.groupBy { it.relay }.mapValues { it.value.map(RelayBasedFilter::filter) }
raw = ctx.drain(filters, timeoutMs = --timeout * 1000 ?: 8_000)
messages = raw.mapNotNull { (relay, event) ->
if (event !is GiftWrapEvent) return@mapNotNull null
val sealed = event.unwrapOrNull(ctx.signer) as? SealedRumorEvent ?: return@mapNotNull null
val inner = sealed.unsealOrNull(ctx.signer) as? ChatMessageEvent ?: return@mapNotNull null
DecryptedMsg(inner, relay, event.id)
}.dedupBy { it.inner.id }
.filter { peerHex == null || peerHex in it.inner.groupMembers() }
.sortedBy { it.inner.createdAt }
.takeLast(limit)
emit:
{ "peer": <hex or null>, "messages": [
{ "id": <kind14 id>, "wrap_id": <1059 id>,
"from": <pubkey>, "to": [<pubkey>...],
"content": <plaintext>, "created_at": <unix>,
"relay": <where wrap was found> }, … ] }
```
Cursor handling: only when `--since` and `--peer` are both absent do we
advance `state.giftWrapSince` to `now()` after a successful drain.
Otherwise the call is a stateless query (parity with how Marmot reads
behave). `GIFT_WRAP_LOOKBACK_SECS` (already defined in `Context.kt`) is
applied automatically by `filterGiftWrapsToPubkey` (it does
`since - twoDays()` itself).
---
## Await flow (`amy dm await`)
Mirror `AwaitCommands.awaitMessage` line-for-line
(`cli/.../commands/AwaitCommands.kt`). Difference: matches against the
unwrapped `ChatMessageEvent.content` instead of a Marmot inner event.
Polls every 2 s, decrypts what arrived, returns the first match or
exits `124`.
```json
{ "id": "<kind14 id>", "from": "<pubkey>", "content": "<text>",
"created_at": <unix>, "wrap_id": "<1059 id>", "relay": "<url>" }
```
---
## Output contract (stable JSON keys)
| Verb | Success keys |
|---|---|
| `dm send` | `event_id` (kind 14), `kind`, `recipients[]{pubkey, wrap_id, published_to[], relays_tried[]}` |
| `dm list` | `peer` (hex or null), `messages[]{id, wrap_id, from, to[], content, created_at, relay}` |
| `dm await` | `id, from, content, created_at, wrap_id, relay` |
Errors (stderr, single-line):
- `bad_args` — missing positional / unparseable `npub`
- `no_dm_relays` — recipient has no kind:10050 and no NIP-65 read
- `no_inbox_relays` — local user has no inbox configured AND no bootstrap
- `runtime` — anything else from `Context`/quartz
- `timeout` (124) — only from `dm await`
Adding a new key later is non-breaking; renaming/removing requires a
note in the commit message.
---
## File layout after the change
```
cli/src/main/kotlin/com/vitorpamplona/amethyst/cli/
├── Main.kt # + "dm" branch → Commands.dm(…)
├── commands/
│ ├── Commands.kt # + suspend fun dm(dataDir, tail)
│ └── DmCommands.kt # NEW: object DmCommands { dispatch, send, list, await }
└── (nothing else)
commons/src/commonMain/kotlin/com/vitorpamplona/amethyst/commons/relayClient/nip17Dm/
└── FilterGiftWrapsToPubkey.kt # NEW (extracted from amethyst/)
amethyst/src/main/java/com/vitorpamplona/amethyst/service/relayClient/reqCommand/account/nip59GiftWraps/
├── AccountGiftWrapsEoseManager.kt # import-only update to point at commons
└── FilterGiftWrapsToPubkey.kt # DELETED in the same commit
```
`README.md` table + `ROADMAP.md` row update in the same PR.
---
## Implementation sequence
Each bullet = one commit.
1. **Extract** `filterGiftWrapsToPubkey` from `amethyst/` to
`commons/.../relayClient/nip17Dm/` and re-point the Android caller.
Run `./gradlew :amethyst:compileDebugKotlin :commons:build`.
2. **Add `amy dm send`** — wires `NIP17Factory` + per-recipient relay
resolution + publish. Manual smoke test: send to self, then to a
second test identity in a separate `--data-dir`.
3. **Add `amy dm list`** — drain + unwrap + JSON. Smoke test reads back
the message published in step 2.
4. **Add `amy dm await`** — polling variant, copy of
`AwaitCommands.awaitMessage` shape.
5. **Docs** — add three rows to `cli/README.md` command table; flip
`cli/ROADMAP.md:55` from 🆕 → ✅; record the JSON shape in the
README's "JSON output" section.
6. **`./gradlew spotlessApply`** before each commit.
---
## Open questions / non-goals
- **Publishing our own kind:10050.** Out of scope; assume the user has
one already (created via Amethyst, or via a future
`amy relay publish-lists --dm`). If missing we still send (using
bootstrap as fallback) but do not auto-publish a list.
- **Reactions / replies / encrypted file attachments (kind 32 with
NIP-17 attachment metadata).** Out of scope — separate plan, if ever.
- **NIP-04 legacy DMs (kind 4).** Not supported. NIP-17-only is a
deliberate choice consistent with `nostr-expert` guidance.
- **Persistent local cache of decrypted messages.** Not in this plan.
Each `amy dm list` re-decrypts; identity-equivalence is by inner
kind:14 id so it remains idempotent. If this becomes a perf issue we
add a `dms/<peer>.log` store mirroring Marmot's pattern — separate
commit.
- **Live subscription (`--watch`).** Out of scope; CLI is one-shot by
Rule 3.
@@ -127,6 +127,10 @@ private suspend fun dispatch(argv: Array<String>): Int {
marmotDispatch(dataDir, tail)
}
"dm" -> {
Commands.dm(dataDir, tail)
}
else -> {
System.err.println("unknown subcommand: $head")
printUsage()
@@ -189,6 +193,19 @@ private fun printUsage() {
| relay list print configured relays
| relay publish-lists publish kind:10002 + kind:10050
|
|Direct messages (NIP-17):
| dm send RECIPIENT TEXT send a gift-wrapped DM
| [--allow-fallback] (default: only deliver to recipient's kind:10050)
| dm send-file RECIPIENT --file PATH encrypt + upload to Blossom + publish kind:15
| --server URL [--mime-type M]
| dm send-file RECIPIENT URL --key HEX reference-mode: file already uploaded
| --nonce HEX [--mime-type M] [--hash H]
| [--size N] [--dim WxH] [--blurhash S]
| dm list [--peer NPUB] [--since TS] list decrypted DMs (kind:14 text +
| [--limit N] [--timeout SECS] kind:15 file with `type` discriminator)
| dm await --peer NPUB --match TEXT wait for a matching DM
| [--timeout SECS] (default 30s, exit 124 on timeout)
|
|Marmot (MLS group messaging):
| marmot key-package publish publish a fresh KeyPackage
| marmot key-package check NPUB fetch NPUB's KeyPackage from relays
@@ -70,4 +70,9 @@ object Commands {
dataDir: DataDir,
tail: Array<String>,
): Int = AwaitCommands.dispatch(dataDir, tail)
suspend fun dm(
dataDir: DataDir,
tail: Array<String>,
): Int = DmCommands.dispatch(dataDir, tail)
}
@@ -0,0 +1,577 @@
/*
* Copyright (c) 2025 Vitor Pamplona
*
* Permission is hereby granted, free of charge, to any person obtaining a copy of
* this software and associated documentation files (the "Software"), to deal in
* the Software without restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the
* Software, and to permit persons to whom the Software is furnished to do so,
* subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in all
* copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
* FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
* COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN
* AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
* WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
*/
package com.vitorpamplona.amethyst.cli.commands
import com.vitorpamplona.amethyst.cli.Args
import com.vitorpamplona.amethyst.cli.AwaitTimeout
import com.vitorpamplona.amethyst.cli.Context
import com.vitorpamplona.amethyst.cli.DataDir
import com.vitorpamplona.amethyst.cli.Json
import com.vitorpamplona.amethyst.commons.relayClient.nip17Dm.filterGiftWrapsToPubkey
import com.vitorpamplona.amethyst.commons.relayClient.nip17Dm.unwrapAndUnsealOrNull
import com.vitorpamplona.amethyst.commons.service.upload.UploadOrchestrator
import com.vitorpamplona.quartz.marmot.RecipientRelayFetcher
import com.vitorpamplona.quartz.nip01Core.core.Event
import com.vitorpamplona.quartz.nip01Core.core.HexKey
import com.vitorpamplona.quartz.nip01Core.core.hexToByteArray
import com.vitorpamplona.quartz.nip01Core.core.toHexKey
import com.vitorpamplona.quartz.nip01Core.relay.normalizer.NormalizedRelayUrl
import com.vitorpamplona.quartz.nip01Core.tags.people.PTag
import com.vitorpamplona.quartz.nip17Dm.NIP17Factory
import com.vitorpamplona.quartz.nip17Dm.base.BaseDMGroupEvent
import com.vitorpamplona.quartz.nip17Dm.files.ChatMessageEncryptedFileHeaderEvent
import com.vitorpamplona.quartz.nip17Dm.messages.ChatMessageEvent
import com.vitorpamplona.quartz.nip59Giftwrap.wraps.GiftWrapEvent
import kotlinx.coroutines.delay
/**
* NIP-17 direct-message verbs. All verbs reuse the Quartz gift-wrap pipeline
* (NIP-17 chat message NIP-59 seal NIP-59 gift wrap via NIP-44) this
* file is pure orchestration over `quartz/` and `commons/`.
*
* Both kind:14 (text) and kind:15 (encrypted file header) are recognised on
* receive; `dm send-file` publishes kind:15 with the AES-GCM key + nonce
* carried in tags per NIP-17.
*
* NIP-17 says clients "shouldn't try" to send when the recipient hasn't
* published a kind:10050. By default we honour that: an empty kind:10050
* is a hard error. `--allow-fallback` opts back into the kind:10002 read
* marker bootstrap chain for the cases (interop tests, brand-new
* accounts) where strict mode is too strict.
*/
object DmCommands {
suspend fun dispatch(
dataDir: DataDir,
tail: Array<String>,
): Int {
if (tail.isEmpty()) return Json.error("bad_args", "dm <send|send-file|list|await> …")
val rest = tail.drop(1).toTypedArray()
return when (tail[0]) {
"send" -> send(dataDir, rest)
"send-file" -> sendFile(dataDir, rest)
"list" -> list(dataDir, rest)
"await" -> await(dataDir, rest)
else -> Json.error("bad_args", "dm ${tail[0]}")
}
}
private suspend fun send(
dataDir: DataDir,
rest: Array<String>,
): Int {
if (rest.size < 2) return Json.error("bad_args", "dm send <recipient> <text> [--allow-fallback]")
val text = rest[1]
val args = Args(rest.drop(2).toTypedArray())
val allowFallback = args.bool("allow-fallback")
val ctx = Context.open(dataDir)
try {
ctx.prepare()
val recipient = ctx.requireUserHex(rest[0])
val template = ChatMessageEvent.build(text, listOf(PTag(recipient)))
val result = NIP17Factory().createMessageNIP17(template, ctx.signer)
return publishWraps(ctx, result, allowFallback)
} finally {
ctx.close()
}
}
/**
* Two modes:
*
* - **Upload mode** (`--file PATH --server URL`): generate a random
* AES-GCM cipher, encrypt the local file, upload the ciphertext to
* the Blossom server, then publish a kind:15 referencing the
* returned URL. The auto-detected hash, size, dimensions, mime
* type, and blurhash from the upload are folded into the event.
*
* - **Reference mode** (positional URL + `--key HEX --nonce HEX`):
* the file is already uploaded somewhere; just publish a kind:15
* pointing at it. Caller-supplied flags fill in the metadata.
*
* Mode selection: the `--file` flag turns on upload mode. Otherwise
* reference mode is required.
*/
private suspend fun sendFile(
dataDir: DataDir,
rest: Array<String>,
): Int {
if (rest.isEmpty()) return Json.error("bad_args", USAGE_SEND_FILE)
val args = Args(rest.drop(1).toTypedArray())
val allowFallback = args.bool("allow-fallback")
val recipientInput = rest[0]
val ctx = Context.open(dataDir)
try {
ctx.prepare()
val recipient = ctx.requireUserHex(recipientInput)
val (template, summary) =
if (args.flag("file") != null) {
buildUploadModeTemplate(ctx, recipient, args)
?: return 1
} else {
buildReferenceModeTemplate(args, recipient)
?: return 1
}
val result = NIP17Factory().createEncryptedFileNIP17(template, ctx.signer)
return publishWraps(ctx, result, allowFallback, extra = summary)
} finally {
ctx.close()
}
}
private suspend fun buildUploadModeTemplate(
ctx: Context,
recipient: com.vitorpamplona.quartz.nip01Core.core.HexKey,
args: Args,
): Pair<com.vitorpamplona.quartz.nip01Core.signers.EventTemplate<ChatMessageEncryptedFileHeaderEvent>, Map<String, Any?>>? {
val file = java.io.File(args.requireFlag("file"))
if (!file.exists()) {
Json.error("bad_args", "file does not exist: ${file.absolutePath}")
return null
}
val server = args.requireFlag("server")
val cipher =
com.vitorpamplona.quartz.utils.ciphers
.AESGCM()
val orchestrator = UploadOrchestrator()
val uploaded = orchestrator.uploadEncrypted(file, cipher, server, ctx.signer)
val uploadedUrl =
uploaded.blossom.url ?: run {
Json.error("upload_failed", "Blossom server $server returned no URL")
return null
}
val mimeType = args.flag("mime-type") ?: uploaded.metadata.mimeType
val dimension =
uploaded.metadata.width?.let { w ->
uploaded.metadata.height?.let { h ->
com.vitorpamplona.quartz.nip94FileMetadata.tags
.DimensionTag(w, h)
}
}
val template =
ChatMessageEncryptedFileHeaderEvent.build(
to = listOf(PTag(recipient)),
url = uploadedUrl,
cipher = cipher,
mimeType = mimeType,
hash = uploaded.encryptedHash,
size = uploaded.encryptedSize,
dimension = dimension,
blurhash = uploaded.metadata.blurhash,
originalHash = uploaded.metadata.sha256,
)
// Surface the cipher material on stdout so callers can re-share
// or republish the same encrypted blob without re-uploading.
val summary =
mapOf(
"url" to uploadedUrl,
"encryption_key" to cipher.keyBytes.toHexKey(),
"encryption_nonce" to cipher.nonce.toHexKey(),
"encrypted_hash" to uploaded.encryptedHash,
"encrypted_size" to uploaded.encryptedSize,
"original_hash" to uploaded.metadata.sha256,
"mime_type" to mimeType,
)
return template to summary
}
private fun buildReferenceModeTemplate(
args: Args,
recipient: com.vitorpamplona.quartz.nip01Core.core.HexKey,
): Pair<com.vitorpamplona.quartz.nip01Core.signers.EventTemplate<ChatMessageEncryptedFileHeaderEvent>, Map<String, Any?>>? {
val url =
args.positionalOrNull(0) ?: run {
Json.error("bad_args", USAGE_SEND_FILE)
return null
}
val keyHex = args.requireFlag("key")
val nonceHex = args.requireFlag("nonce")
val keyBytes =
runCatching { keyHex.hexToByteArray() }.getOrElse {
Json.error("bad_args", "--key must be hex (got ${keyHex.length} chars)")
return null
}
val nonceBytes =
runCatching { nonceHex.hexToByteArray() }.getOrElse {
Json.error("bad_args", "--nonce must be hex (got ${nonceHex.length} chars)")
return null
}
val mimeType = args.flag("mime-type")
val hash = args.flag("hash")
val originalHash = args.flag("original-hash")
val size = args.flags["size"]?.toIntOrNull()
val blurhash = args.flag("blurhash")
val dimension =
args.flag("dim")?.let { raw ->
val match =
Regex("^(\\d+)x(\\d+)$").matchEntire(raw)
?: run {
Json.error("bad_args", "--dim must be WxH (got '$raw')")
return null
}
com.vitorpamplona.quartz.nip94FileMetadata.tags
.DimensionTag(match.groupValues[1].toInt(), match.groupValues[2].toInt())
}
val cipher =
com.vitorpamplona.quartz.utils.ciphers
.AESGCM(keyBytes, nonceBytes)
val template =
ChatMessageEncryptedFileHeaderEvent.build(
to = listOf(PTag(recipient)),
url = url,
cipher = cipher,
mimeType = mimeType,
hash = hash,
size = size,
dimension = dimension,
blurhash = blurhash,
originalHash = originalHash,
)
return template to emptyMap()
}
private const val USAGE_SEND_FILE: String =
"dm send-file <recipient> [--file PATH --server URL | URL --key HEX --nonce HEX] " +
"[--mime-type M] [--hash HEX] [--original-hash HEX] [--size N] [--dim WxH] [--blurhash S] [--allow-fallback]"
private suspend fun publishWraps(
ctx: Context,
result: NIP17Factory.Result,
allowFallback: Boolean,
extra: Map<String, Any?> = emptyMap(),
): Int {
val recipientsOut = mutableListOf<Map<String, Any?>>()
for (wrap in result.wraps) {
val target = wrap.recipientPubKey() ?: continue
val resolution = resolveDmRelays(ctx, target, allowFallback)
if (resolution.relays.isEmpty()) {
return Json.error(
"no_dm_relays",
"$target has no kind:10050; pass --allow-fallback to use NIP-65 read or bootstrap",
)
}
val ack = ctx.publish(wrap, resolution.relays)
recipientsOut.add(
mapOf(
"pubkey" to target,
"wrap_id" to wrap.id,
"published_to" to ack.filterValues { it }.keys.map { it.url },
"relays_tried" to resolution.relays.map { it.url },
"relay_source" to resolution.source,
),
)
}
val out =
buildMap {
put("event_id", result.msg.id)
put("kind", result.msg.kind)
putAll(extra)
put("recipients", recipientsOut)
}
Json.writeLine(out)
return 0
}
private suspend fun list(
dataDir: DataDir,
rest: Array<String>,
): Int {
val args = Args(rest)
val peerInput = args.flag("peer")
val sinceFlag = args.flags["since"]?.toLongOrNull()
val limit = args.intFlag("limit", Int.MAX_VALUE)
val timeoutSecs = args.longFlag("timeout", 8)
val ctx = Context.open(dataDir)
try {
ctx.prepare()
val peerHex = peerInput?.let { ctx.requireUserHex(it) }
val inbox =
ctx
.inboxRelays()
.ifEmpty { ctx.outboxRelays() }
.ifEmpty { ctx.bootstrapRelays() }
if (inbox.isEmpty()) return Json.error("no_inbox_relays", "configure relays or bootstrap defaults first")
val advanceCursor = peerInput == null && sinceFlag == null
val since = sinceFlag ?: ctx.state.giftWrapSince
val filters =
inbox
.flatMap { filterGiftWrapsToPubkey(it, ctx.signer.pubKey, since) }
.groupBy { it.relay }
.mapValues { (_, v) -> v.map { it.filter } }
val raw = ctx.drain(filters, timeoutMs = timeoutSecs * 1000)
val messages = decryptDms(ctx, raw, peerHex)
val out =
messages
.sortedBy { it.createdAt }
.takeLast(limit)
.map { it.toJson() }
if (advanceCursor) {
val maxSeen = messages.maxOfOrNull { it.createdAt }
if (maxSeen != null) ctx.state.giftWrapSince = maxSeen
}
Json.writeLine(
mapOf(
"peer" to peerHex,
"messages" to out,
),
)
return 0
} finally {
ctx.close()
}
}
private suspend fun await(
dataDir: DataDir,
rest: Array<String>,
): Int {
val args = Args(rest)
val peerInput = args.requireFlag("peer")
val match = args.requireFlag("match")
val timeoutSecs = args.longFlag("timeout", 30)
val ctx = Context.open(dataDir)
try {
ctx.prepare()
val peerHex = ctx.requireUserHex(peerInput)
val inbox =
ctx
.inboxRelays()
.ifEmpty { ctx.outboxRelays() }
.ifEmpty { ctx.bootstrapRelays() }
if (inbox.isEmpty()) return Json.error("no_inbox_relays", "configure relays or bootstrap defaults first")
val deadline = System.currentTimeMillis() + timeoutSecs * 1000
var since = ctx.state.giftWrapSince
while (System.currentTimeMillis() < deadline) {
val filters =
inbox
.flatMap { filterGiftWrapsToPubkey(it, ctx.signer.pubKey, since) }
.groupBy { it.relay }
.mapValues { (_, v) -> v.map { it.filter } }
val raw = ctx.drain(filters, timeoutMs = 3_000)
val messages = decryptDms(ctx, raw, peerHex)
// Match against the text body for kind:14 and against the URL
// for kind:15 — both are exposed as `searchText` so callers
// can grep for either with one --match flag.
val hit = messages.firstOrNull { match in it.searchText }
if (hit != null) {
Json.writeLine(hit.toJson())
return 0
}
val maxSeen = messages.maxOfOrNull { it.createdAt }
if (maxSeen != null && (since == null || maxSeen > since)) since = maxSeen
delay(2_000)
}
throw AwaitTimeout("no DM from $peerHex matching '$match' within ${timeoutSecs}s")
} finally {
ctx.close()
}
}
/**
* Per NIP-17: kind:1059 should only be delivered to relays the recipient
* has advertised in their kind:10050. When that list is empty:
* - strict (default): refuse with no_dm_relays caller must fix or
* explicitly opt into a fallback.
* - allowFallback=true: fall through to the NIP-65 read marker and then
* to our bootstrap pool.
*/
private suspend fun resolveDmRelays(
ctx: Context,
recipient: HexKey,
allowFallback: Boolean,
): RelaySet {
val seed = ctx.bootstrapRelays()
val lists = RecipientRelayFetcher.fetchRelayLists(ctx.client, recipient, seed)
val dmInbox = lists.dmInbox.toSet()
if (dmInbox.isNotEmpty()) return RelaySet(dmInbox, "kind_10050")
if (!allowFallback) return RelaySet(emptySet(), "kind_10050")
val nip65Read = lists.nip65Read().toSet()
if (nip65Read.isNotEmpty()) return RelaySet(nip65Read, "nip65_read")
return RelaySet(seed, "bootstrap")
}
private data class RelaySet(
val relays: Set<NormalizedRelayUrl>,
val source: String,
)
private sealed interface DecryptedDm {
val id: HexKey
val wrapId: HexKey
val from: HexKey
val to: List<HexKey>
val createdAt: Long
val relay: String
val searchText: String
fun toJson(): Map<String, Any?>
}
private data class TextDm(
override val id: HexKey,
override val wrapId: HexKey,
override val from: HexKey,
override val to: List<HexKey>,
val content: String,
override val createdAt: Long,
override val relay: String,
) : DecryptedDm {
override val searchText: String get() = content
override fun toJson(): Map<String, Any?> =
mapOf(
"type" to "text",
"id" to id,
"wrap_id" to wrapId,
"from" to from,
"to" to to,
"content" to content,
"created_at" to createdAt,
"relay" to relay,
)
}
private data class FileDm(
override val id: HexKey,
override val wrapId: HexKey,
override val from: HexKey,
override val to: List<HexKey>,
val url: String,
val mimeType: String?,
val encryptionAlgo: String?,
val decryptionKey: String?,
val decryptionNonce: String?,
val hash: String?,
val originalHash: String?,
val size: Int?,
val dimensions: String?,
val blurhash: String?,
override val createdAt: Long,
override val relay: String,
) : DecryptedDm {
override val searchText: String get() = url
override fun toJson(): Map<String, Any?> {
val out =
mutableMapOf<String, Any?>(
"type" to "file",
"id" to id,
"wrap_id" to wrapId,
"from" to from,
"to" to to,
"url" to url,
"created_at" to createdAt,
"relay" to relay,
)
if (mimeType != null) out["mime_type"] = mimeType
if (encryptionAlgo != null) out["encryption_algorithm"] = encryptionAlgo
if (decryptionKey != null) out["decryption_key"] = decryptionKey
if (decryptionNonce != null) out["decryption_nonce"] = decryptionNonce
if (hash != null) out["hash"] = hash
if (originalHash != null) out["original_hash"] = originalHash
if (size != null) out["size"] = size
if (dimensions != null) out["dim"] = dimensions
if (blurhash != null) out["blurhash"] = blurhash
return out
}
}
private suspend fun decryptDms(
ctx: Context,
raw: List<Pair<NormalizedRelayUrl, Event>>,
peerHex: HexKey?,
): List<DecryptedDm> {
val seen = HashSet<HexKey>()
val out = mutableListOf<DecryptedDm>()
for ((relay, event) in raw) {
if (event !is GiftWrapEvent) continue
// Quartz's Rumor.mergeWith forces the inner event's pubkey to the
// seal author's, so the NIP-17 §7 step-3 impersonation check is
// already enforced upstream — no need to redo it here.
val inner = event.unwrapAndUnsealOrNull(ctx.signer) ?: continue
if (inner !is BaseDMGroupEvent) continue
if (!seen.add(inner.id)) continue
if (peerHex != null && peerHex !in inner.groupMembers()) continue
out.add(toDecrypted(inner, event.id, relay.url) ?: continue)
}
return out
}
private fun toDecrypted(
inner: BaseDMGroupEvent,
wrapId: HexKey,
relayUrl: String,
): DecryptedDm? =
when (inner) {
is ChatMessageEvent -> {
TextDm(
id = inner.id,
wrapId = wrapId,
from = inner.pubKey,
to = inner.recipientsPubKey(),
content = inner.content,
createdAt = inner.createdAt,
relay = relayUrl,
)
}
is ChatMessageEncryptedFileHeaderEvent -> {
FileDm(
id = inner.id,
wrapId = wrapId,
from = inner.pubKey,
to = inner.recipientsPubKey(),
url = inner.url(),
mimeType = inner.mimeType(),
encryptionAlgo = inner.algo(),
decryptionKey = inner.key()?.toHexKey(),
decryptionNonce = inner.nonce()?.toHexKey(),
hash = inner.hash(),
originalHash = inner.originalHash(),
size = inner.size(),
dimensions = inner.dimensions()?.let { "${it.width}x${it.height}" },
blurhash = inner.blurhash(),
createdAt = inner.createdAt,
relay = relayUrl,
)
}
else -> {
null
}
}
}
+3
View File
@@ -0,0 +1,3 @@
marmot/state/
marmot/state-headless/
dm/state-dm-headless/
@@ -1,16 +1,47 @@
# Marmot Interop Test Harness
# amy CLI test harnesses
Two flavours, same scenarios:
Shell-based end-to-end harnesses that drive the `amy` CLI binary against a
loopback `nostr-rs-relay`. Layout:
- **`marmot-interop.sh`** — interactive. Drives B/C via `wn` and **prompts the
human** to perform each Amethyst-side step in the mobile UI (Identity A).
Use this for final UI verification.
- **`marmot-interop-headless.sh`** — zero prompts. Drives A via the `amy` CLI
(`./gradlew :cli:installDist`) and B/C via `wn`. Runs every scenario
end-to-end and exits with a pass/fail summary. Use this for CI and for
iterating on the Nostr/Marmot plumbing without needing to touch a phone.
```
cli/tests/
├── lib.sh # shared logging, results, assertions
├── headless/ # shared bits used by every harness
│ └── helpers.sh
├── marmot/ # Marmot / MLS group-messaging interop
│ ├── marmot-interop.sh # interactive — prompts Amethyst Android UI
│ ├── marmot-interop-headless.sh # zero-prompt
│ ├── setup.sh # preflight + wn + relay + identities
│ ├── tests-create.sh # tests 0105
│ ├── tests-manage.sh # tests 0608, 11
│ ├── tests-extras.sh # tests 09, 10, 12, 13
│ └── patches/ # whitenoise-rs harness patches
└── dm/ # NIP-17 DM interop (amy ↔ amy)
├── dm-interop-headless.sh
├── setup.sh # preflight + identities
└── tests-dm.sh
```
Both harnesses validate Amethyst against **whitenoise-rs**
The Marmot harnesses come in two flavours, same scenarios:
- **`marmot/marmot-interop.sh`** — interactive. Drives B/C via `wn` and
**prompts the human** to perform each Amethyst-side step in the mobile UI
(Identity A). Use this for final UI verification.
- **`marmot/marmot-interop-headless.sh`** — zero prompts. Drives A via the
`amy` CLI (`./gradlew :cli:installDist`) and B/C via `wn`. Runs every
scenario end-to-end and exits with a pass/fail summary. Use this for CI
and for iterating on the Nostr/Marmot plumbing without needing to touch a
phone.
A third, slimmer harness covers the NIP-17 DM surface:
- **`dm/dm-interop-headless.sh`** — two `amy` processes (Identity A and
Identity D) exchange NIP-17 DMs through the loopback nostr-rs-relay.
No whitenoise-rs required — only `amy` and the relay binary (which
is shared with the Marmot harness's checkout at
`marmot/state-headless/nostr-rs-relay/`).
Both Marmot harnesses validate Amethyst against **whitenoise-rs**
(https://github.com/marmot-protocol/whitenoise-rs), the reference Rust
implementation that powers the White Noise Flutter app. Every test records a
pass/fail/skip result into a tab-separated log, and the summary is printed at
@@ -33,6 +64,31 @@ the end of the run.
| 11 | Leave group | |
| 12 | Offline catch-up / replay | |
| 13 | KeyPackage rotation | |
### DM (amy ↔ amy, NIP-17) — `dm/dm-interop-headless.sh`
| # | Test |
|---|---|
| dm-01 | Text round-trip A↔D (kind:14) |
| dm-02 | `dm list` returns prior exchange with `type:text` discriminator |
| dm-03 | Strict kind:10050 refuses sends to an inboxless recipient |
| dm-04 | `--allow-fallback` opts into the NIP-65 read / bootstrap chain |
| dm-05 | File message reference mode round-trip (kind:15 with manual key/nonce) |
| dm-06 | `dm list --since` filters out older messages (window-slide past the newest event returns 0) |
**Relay binding note:** the DM harness binds the loopback relay to
`127.0.0.2` (not `127.0.0.1`) because Quartz's `RelayTag.parse` rejects
localhost URLs via `isLocalHost()` — so `ws://127.0.0.1` in a kind:10050
event is silently stripped during recipient-relay resolution, which
would make strict-mode DM sends spuriously fail. `127.0.0.2` is still
pure loopback and isn't matched by that filter. Override with
`--host 127.0.0.5` etc. if `127.0.0.2` is taken.
**Note:** dm-05 validates the kind:15 wire format via reference mode
(caller supplies the URL + AES-GCM key/nonce). The upload-mode variant
(`dm send-file --file PATH --server URL`) needs a local Blossom server
and isn't scripted here — the upload classes are unit-tested on desktop
at `desktopApp/src/jvmTest/kotlin/.../service/upload/`.
| 14 | Push notifications (MIP-05) | opt-in via `--transponder` |
## Prerequisites
+106
View File
@@ -0,0 +1,106 @@
#!/usr/bin/env bash
#
# dm-interop-headless.sh — zero-prompt NIP-17 DM interop harness.
#
# Two `amy` processes (Identity A and Identity D) talk to each other
# through a local nostr-rs-relay on ws://127.0.0.1:$RELAY_PORT. No
# whitenoise-rs, no Marmot, no public internet traffic.
#
# Usage: ./dm-interop-headless.sh [--port N] [--no-build]
#
set -uo pipefail
SCRIPT_DIR="$(cd -- "$(dirname -- "${BASH_SOURCE[0]}")" && pwd)"
REPO_ROOT="$(cd -- "$SCRIPT_DIR/../../.." && pwd)"
TESTS_DIR="$(cd -- "$SCRIPT_DIR/.." && pwd)"
STATE_DIR="$SCRIPT_DIR/state-dm-headless"
LOG_DIR="$STATE_DIR/logs"
A_DIR="$STATE_DIR/A"
D_DIR="$STATE_DIR/D"
RUN_TS="$(date +%Y%m%d-%H%M%S)"
LOG_FILE="$LOG_DIR/run-$RUN_TS.log"
RESULTS_FILE="$STATE_DIR/results-$RUN_TS.tsv"
AMY_BIN="$REPO_ROOT/cli/build/install/amy/bin/amy"
# Share the nostr-rs-relay checkout with the Marmot harness to avoid
# rebuilding it twice. Override RELAY_REPO / RELAY_DATA if you want full
# isolation between runs.
# Bind the loopback relay to 127.0.0.2 rather than 127.0.0.1 so Quartz's
# `isLocalHost()` filter doesn't silently strip it out of the kind:10050
# inbox events during recipient-relay resolution. 127.0.0.2 is still pure
# loopback — no network traffic, no config needed.
RELAY_HOST="${RELAY_HOST:-127.0.0.2}"
RELAY_REPO="${RELAY_REPO:-$TESTS_DIR/marmot/state-headless/nostr-rs-relay}"
RELAY_BIN="$RELAY_REPO/target/release/nostr-rs-relay"
RELAY_DATA="$STATE_DIR/relay"
RELAY_PORT="${RELAY_PORT:-8090}"
RELAY_URL="ws://$RELAY_HOST:$RELAY_PORT"
NO_BUILD=0
A_NPUB=""
A_HEX=""
D_NPUB=""
D_HEX=""
while [[ $# -gt 0 ]]; do
case "$1" in
--port) RELAY_PORT="$2"; RELAY_URL="ws://$RELAY_HOST:$RELAY_PORT"; shift ;;
--host) RELAY_HOST="$2"; RELAY_URL="ws://$RELAY_HOST:$RELAY_PORT"; shift ;;
--no-build) NO_BUILD=1 ;;
-h|--help)
sed -n '3,12p' "${BASH_SOURCE[0]}" | sed 's/^# \?//'
exit 0 ;;
*) printf 'unknown flag: %s\n' "$1" >&2; exit 2 ;;
esac
shift
done
mkdir -p "$STATE_DIR" "$LOG_DIR" "$A_DIR" "$D_DIR"
: >"$LOG_FILE"
: >"$RESULTS_FILE"
# Reuse the logging + result helpers shared between every harness.
# lib.sh declares wn-specific helpers too — harmless when unused.
# shellcheck source=../lib.sh
source "$TESTS_DIR/lib.sh"
# Reuse start_local_relay / stop_local_relay from the Marmot harness's
# setup.sh — the relay lifecycle is identical. preflight() there also
# builds whitenoise-rs, which we don't need; setup.sh in this dir
# defines a slimmer preflight_dm().
# shellcheck source=../marmot/setup.sh
source "$TESTS_DIR/marmot/setup.sh"
# shellcheck source=setup.sh
source "$SCRIPT_DIR/setup.sh"
# shellcheck source=../headless/helpers.sh
source "$TESTS_DIR/headless/helpers.sh"
# shellcheck source=tests-dm.sh
source "$SCRIPT_DIR/tests-dm.sh"
cleanup() {
local rc=$?
trap - EXIT INT TERM HUP
stop_local_relay
print_summary
exit "$rc"
}
trap cleanup EXIT
trap 'exit 130' INT
trap 'exit 143' TERM
trap 'exit 129' HUP
banner "Amethyst NIP-17 DM headless interop ($RUN_TS)"
preflight_dm
start_local_relay
ensure_identity_for A "$A_DIR"
ensure_identity_for D "$D_DIR"
configure_relays_dm
test_01_dm_text_round_trip
test_02_dm_list_surfaces_history
test_03_dm_send_rejects_no_inbox
test_04_dm_send_allow_fallback
test_05_dm_file_reference_round_trip
test_06_dm_list_since_filter
+112
View File
@@ -0,0 +1,112 @@
# shellcheck shell=bash
#
# setup.sh — amy-only preflight + identity bootstrap for the
# NIP-17 DM interop harness. Much slimmer than the Marmot setup:
#
# - Builds `amy` (same retry-on-503 logic as setup.sh).
# - Builds nostr-rs-relay if missing.
# - Bootstraps two fresh amy identities (A and D), each with its own
# `--data-dir`, both pointed at the loopback relay.
# - Publishes kind:10050 (plus NIP-65) for both so NIP-17's strict
# recipient-inbox routing has something to resolve to.
#
# The heavy `start_local_relay` / `stop_local_relay` helpers live in
# the Marmot harness's setup.sh and are sourced by the top-level harness.
# --- preflight (amy + relay only, no wn / Marmot patches) -------------------
preflight_dm() {
banner "Preflight (DM harness)"
for cmd in jq git cargo; do
if ! command -v "$cmd" >/dev/null 2>&1; then
fail_msg "missing required tool: $cmd"
exit 1
fi
info "$cmd: $(command -v "$cmd")"
done
if [[ ! -x "$AMY_BIN" ]]; then
if [[ "$NO_BUILD" -eq 1 ]]; then
fail_msg "amy not found at $AMY_BIN and --no-build set"; exit 1
fi
# Gradle + jitpack/dl.google.com occasionally return transient 503s;
# retry so a single bad roll doesn't tank the whole harness.
local attempt max=4
for attempt in $(seq 1 $max); do
step "building :cli:installDist (attempt $attempt/$max)"
if ( cd "$REPO_ROOT" && ./gradlew :cli:installDist ) 2>&1 | tee -a "$LOG_FILE" \
&& [[ -x "$AMY_BIN" ]]; then
break
fi
[[ "$attempt" -lt "$max" ]] && warn "gradle build failed — retrying"
done
fi
[[ -x "$AMY_BIN" ]] || { fail_msg "amy still missing after build"; exit 1; }
info "amy: $AMY_BIN"
# nostr-rs-relay (same build path as the Marmot harness).
if [[ ! -x "$RELAY_BIN" ]]; then
if [[ "$NO_BUILD" -eq 1 ]]; then
fail_msg "nostr-rs-relay not found at $RELAY_BIN and --no-build set"; exit 1
fi
if [[ ! -d "$RELAY_REPO/.git" ]]; then
step "cloning nostr-rs-relay into $RELAY_REPO"
git clone --depth 1 https://github.com/scsibug/nostr-rs-relay "$RELAY_REPO" \
2>&1 | tee -a "$LOG_FILE"
fi
local attempt max=4
for attempt in $(seq 1 $max); do
step "building nostr-rs-relay (attempt $attempt/$max, ~3 min first run)"
( cd "$RELAY_REPO" && cargo build --release --bin nostr-rs-relay ) \
2>&1 | tee -a "$LOG_FILE"
[[ -x "$RELAY_BIN" ]] && break
[[ "$attempt" -lt "$max" ]] && warn "nostr-rs-relay build failed — retrying"
done
[[ -x "$RELAY_BIN" ]] || {
fail_msg "nostr-rs-relay still missing after $max attempts"; exit 1
}
fi
info "relay bin: $RELAY_BIN"
}
# --- amy identity wrappers ---------------------------------------------------
# Two identities: A (sender) and D (recipient). We reuse A_DIR for parity
# with the existing harness files; D_DIR is new.
amy_a() { "$AMY_BIN" --data-dir "$A_DIR" "$@"; }
amy_d() { "$AMY_BIN" --data-dir "$D_DIR" "$@"; }
# --- identity bootstrap ------------------------------------------------------
ensure_identity_for() {
local who="$1" dir="$2"
step "initialising Identity $who (amy at $dir)"
local out
out=$("$AMY_BIN" --data-dir "$dir" init) || {
fail_msg "amy init failed for $who: $out"; exit 1
}
local npub hex
npub=$(printf '%s' "$out" | jq -r '.npub')
hex=$(printf '%s' "$out" | jq -r '.hex')
case "$who" in
A) A_NPUB="$npub"; A_HEX="$hex" ;;
D) D_NPUB="$npub"; D_HEX="$hex" ;;
esac
info "$who npub: $npub"
info "$who hex: $hex"
}
# --- relay wiring ------------------------------------------------------------
# Point both identities at the loopback relay (all three buckets:
# nip65 / inbox / key_package), then publish each identity's kind:10050
# so the DM strict-relay routing has something to resolve to.
configure_relays_dm() {
banner "Configuring relays → $RELAY_URL"
"$AMY_BIN" --data-dir "$A_DIR" relay add "$RELAY_URL" --type all >/dev/null
"$AMY_BIN" --data-dir "$D_DIR" relay add "$RELAY_URL" --type all >/dev/null
step "publishing A's NIP-65 + kind:10050 lists"
amy_a relay publish-lists >>"$LOG_FILE" 2>&1 \
|| warn "amy_a relay publish-lists failed"
step "publishing D's NIP-65 + kind:10050 lists"
amy_d relay publish-lists >>"$LOG_FILE" 2>&1 \
|| warn "amy_d relay publish-lists failed"
}
+230
View File
@@ -0,0 +1,230 @@
# shellcheck shell=bash
#
# tests-dm.sh — NIP-17 DM interop tests for two `amy` clients.
#
# Identity A (sender) and Identity D (recipient) each live in their own
# --data-dir and share one loopback nostr-rs-relay. Tests cover:
#
# dm-01 text round-trip (both directions)
# dm-02 dm list surfaces prior exchange with type:text discriminator
# dm-03 strict kind:10050 routing refuses sends to inboxless recipient
# dm-04 --allow-fallback opts into the NIP-65 read / bootstrap chain
# dm-05 file message reference mode round-trip (kind:15)
# dm-06 cursor advance (subsequent no-flag `dm list` is empty)
# Wrap amy_json around either data-dir so the per-test code stays tight.
amy_json_for() {
local dir="$1"; shift
local out
if ! out=$("$AMY_BIN" --data-dir "$dir" "$@" 2>>"$LOG_FILE"); then
fail_msg "amy --data-dir $dir $*: exit $? (see $LOG_FILE)"
printf '%s\n' "$out" >>"$LOG_FILE"
return 1
fi
printf '%s' "$out"
}
amy_json_a() { amy_json_for "$A_DIR" "$@"; }
amy_json_d() { amy_json_for "$D_DIR" "$@"; }
test_01_dm_text_round_trip() {
banner "DM-01 — text round-trip A↔D (kind:14)"
local id="dm-01 text round-trip"
# A → D
local out_send
out_send=$(amy_json_a dm send "$D_NPUB" "hello from A") || {
record_result "$id" fail "A send failed"; return
}
local event_id recipients_ok
event_id=$(printf '%s' "$out_send" | jq -r '.event_id')
recipients_ok=$(printf '%s' "$out_send" \
| jq -r '[.recipients[] | select(.relay_source == "kind_10050")] | length')
info "A sent kind:14 event_id=$event_id (to ${recipients_ok} kind:10050 inboxes)"
if [[ -z "$event_id" || "$event_id" == "null" ]]; then
record_result "$id" fail "A send response missing event_id"; return
fi
# D awaits the text
if ! amy_json_d dm await --peer "$A_NPUB" --match "hello from A" --timeout 30 >/dev/null; then
record_result "$id" fail "D never received A's text"; return
fi
info "D received A's text"
# D → A
amy_json_d dm send "$A_NPUB" "reply from D" >/dev/null || {
record_result "$id" fail "D send failed"; return
}
if ! amy_json_a dm await --peer "$D_NPUB" --match "reply from D" --timeout 30 >/dev/null; then
record_result "$id" fail "A never received D's reply"; return
fi
info "A received D's reply"
record_result "$id" pass
}
test_02_dm_list_surfaces_history() {
banner "DM-02 — dm list returns text messages with type discriminator"
local id="dm-02 dm list text history"
local out
out=$(amy_json_a dm list --peer "$D_NPUB" --timeout 5) || {
record_result "$id" fail "amy dm list failed"; return
}
local text_count reply_present
text_count=$(printf '%s' "$out" \
| jq -r '[.messages[] | select(.type == "text")] | length')
reply_present=$(printf '%s' "$out" \
| jq -r '[.messages[] | select(.content == "reply from D")] | length')
info "A sees $text_count text message(s) with D; reply_present=$reply_present"
if [[ "$reply_present" == "1" ]]; then
record_result "$id" pass
else
record_result "$id" fail "D's reply missing from A's dm list"
fi
}
test_03_dm_send_rejects_no_inbox() {
banner "DM-03 — strict kind:10050 refuses sends to inboxless recipient"
local id="dm-03 strict no_dm_relays"
# Generate a throwaway identity but do NOT publish its kind:10050.
local tmpdir; tmpdir=$(mktemp -d "${STATE_DIR}/ghost.XXXXXX")
local ghost_out ghost_npub
ghost_out=$("$AMY_BIN" --data-dir "$tmpdir" init) || {
record_result "$id" fail "ghost init failed"; rm -rf "$tmpdir"; return
}
ghost_npub=$(printf '%s' "$ghost_out" | jq -r '.npub')
info "ghost: $ghost_npub (no relays advertised)"
# A sends without --allow-fallback; amy should refuse.
local raw rc
raw=$("$AMY_BIN" --data-dir "$A_DIR" dm send "$ghost_npub" "should be rejected" 2>&1)
rc=$?
rm -rf "$tmpdir"
if [[ "$rc" -ne 0 ]] && printf '%s' "$raw" | grep -q '"error":"no_dm_relays"'; then
info "amy refused with no_dm_relays as expected (exit $rc)"
record_result "$id" pass
else
fail_msg "expected no_dm_relays error; got rc=$rc raw=$raw"
record_result "$id" fail "send to inboxless recipient did not refuse"
fi
}
test_04_dm_send_allow_fallback() {
banner "DM-04 — --allow-fallback opts into NIP-65 read / bootstrap chain"
local id="dm-04 allow-fallback"
# Same ghost pattern as dm-03. With --allow-fallback, resolution should
# fall through kind:10050 → NIP-65 read → bootstrap. Our bootstrap set
# always includes the loopback relay via the shared RelayConfig, so the
# publish should succeed even though the ghost has no 10050.
local tmpdir; tmpdir=$(mktemp -d "${STATE_DIR}/ghost.XXXXXX")
local ghost_out ghost_npub
ghost_out=$("$AMY_BIN" --data-dir "$tmpdir" init) || {
record_result "$id" fail "ghost init failed"; rm -rf "$tmpdir"; return
}
ghost_npub=$(printf '%s' "$ghost_out" | jq -r '.npub')
rm -rf "$tmpdir"
local out source
out=$(amy_json_a dm send "$ghost_npub" "hi via fallback" --allow-fallback) || {
record_result "$id" fail "send with --allow-fallback failed"; return
}
# The ghost's own wrap will land in the recipients list; its source
# should be bootstrap (no 10050, no 10002) — which confirms the
# fallback actually fired.
source=$(printf '%s' "$out" \
| jq -r --arg pk "${ghost_npub}" \
'.recipients[] | select(.pubkey != $pk) | .relay_source' \
| head -1)
info "relay_source for ghost wrap: $source"
if printf '%s' "$out" | jq -e '[.recipients[] | .relay_source] | index("bootstrap")' >/dev/null \
|| printf '%s' "$out" | jq -e '[.recipients[] | .relay_source] | index("nip65_read")' >/dev/null; then
record_result "$id" pass
else
record_result "$id" fail "no recipient reported a fallback relay_source"
fi
}
test_05_dm_file_reference_round_trip() {
banner "DM-05 — file message reference mode (kind:15) round-trip"
local id="dm-05 file reference round-trip"
# 64 hex chars = 32-byte AES-GCM key; 32 hex chars = 16-byte nonce.
local key="0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef"
local nonce="fedcba9876543210fedcba9876543210"
local url="https://example.test/blob/test-dm-05.bin"
local mime="application/octet-stream"
amy_json_a dm send-file "$D_NPUB" "$url" \
--key "$key" --nonce "$nonce" --mime-type "$mime" --size 1024 >/dev/null || {
record_result "$id" fail "A send-file failed"; return
}
info "A published kind:15 for $url"
# D awaits — `dm await --match` searches URL for kind:15.
if ! amy_json_d dm await --peer "$A_NPUB" --match "$url" --timeout 30 >/dev/null; then
record_result "$id" fail "D never received the file message"; return
fi
# Verify the recovered JSON carries all crypto material.
local raw
raw=$(amy_json_d dm list --peer "$A_NPUB" --timeout 5) || {
record_result "$id" fail "D dm list failed"; return
}
local fields
fields=$(printf '%s' "$raw" | jq -r \
'[.messages[] | select(.type == "file" and .url == "'"$url"'")][0]')
if [[ -z "$fields" || "$fields" == "null" ]]; then
record_result "$id" fail "D did not decode a kind:15 matching the URL"; return
fi
local got_key got_nonce got_mime
got_key=$(printf '%s' "$fields" | jq -r '.decryption_key')
got_nonce=$(printf '%s' "$fields" | jq -r '.decryption_nonce')
got_mime=$(printf '%s' "$fields" | jq -r '.mime_type')
info "D decoded key=${got_key:0:16}… nonce=${got_nonce:0:16}… mime=$got_mime"
assert_eq "$got_key" "$key" "$id" "decryption_key mismatch" || return
assert_eq "$got_nonce" "$nonce" "$id" "decryption_nonce mismatch" || return
assert_eq "$got_mime" "$mime" "$id" "mime_type mismatch" || return
record_result "$id" pass
}
test_06_dm_list_since_filter() {
banner "DM-06 — --since filters out older messages"
local id="dm-06 since filter"
# Baseline: a --peer query (stateless) should surface every message so
# far. We need at least one to have a meaningful window to slide past.
local baseline baseline_count
baseline=$(amy_json_d dm list --peer "$A_NPUB" --timeout 5) || {
record_result "$id" fail "baseline dm list failed"; return
}
baseline_count=$(printf '%s' "$baseline" | jq -r '.messages | length')
info "baseline messages with A: $baseline_count"
if [[ "$baseline_count" -lt 1 ]]; then
record_result "$id" fail "no messages to filter — earlier tests didn't populate"; return
fi
# Now query with --since set to a timestamp 2 days after the newest
# message. filterGiftWrapsToPubkey subtracts its own two-day lookback
# window, so the effective `since` lands right after the newest event
# — nothing should come back.
local newest
newest=$(printf '%s' "$baseline" | jq -r '[.messages[].created_at] | max')
local future=$(( newest + 2 * 24 * 60 * 60 + 3600 ))
local after after_count
after=$(amy_json_d dm list --peer "$A_NPUB" --since "$future" --timeout 5) || {
record_result "$id" fail "since-query failed"; return
}
after_count=$(printf '%s' "$after" | jq -r '.messages | length')
info "after --since $future: $after_count message(s)"
if [[ "$after_count" -eq 0 ]]; then
record_result "$id" pass
else
record_result "$id" fail "expected 0 after future --since; got $after_count"
fi
}
@@ -1,6 +1,6 @@
# shellcheck shell=bash
#
# headless/helpers.sh — thin wrappers that keep the per-test code tight.
# helpers.sh — thin wrappers that keep the per-test code tight.
# --- amy wrapper -------------------------------------------------------------
amy_a() { "$AMY_BIN" --data-dir "$A_DIR" "$@"; }
@@ -14,7 +14,8 @@
set -uo pipefail
SCRIPT_DIR="$(cd -- "$(dirname -- "${BASH_SOURCE[0]}")" && pwd)"
REPO_ROOT="$(cd -- "$SCRIPT_DIR/../.." && pwd)"
REPO_ROOT="$(cd -- "$SCRIPT_DIR/../../.." && pwd)"
TESTS_DIR="$(cd -- "$SCRIPT_DIR/.." && pwd)"
STATE_DIR="$SCRIPT_DIR/state-headless"
LOG_DIR="$STATE_DIR/logs"
A_DIR="$STATE_DIR/A"
@@ -66,19 +67,19 @@ mkdir -p "$STATE_DIR" "$LOG_DIR" "$A_DIR" "$B_DIR/logs" "$C_DIR/logs"
: >"$RESULTS_FILE"
# Reuse colours / logging / dump_daemon_diagnostics from the interactive harness.
# shellcheck source=lib.sh
source "$SCRIPT_DIR/lib.sh"
# shellcheck source=../lib.sh
source "$TESTS_DIR/lib.sh"
# shellcheck source=headless/setup.sh
source "$SCRIPT_DIR/headless/setup.sh"
# shellcheck source=headless/helpers.sh
source "$SCRIPT_DIR/headless/helpers.sh"
# shellcheck source=headless/tests-create.sh
source "$SCRIPT_DIR/headless/tests-create.sh"
# shellcheck source=headless/tests-manage.sh
source "$SCRIPT_DIR/headless/tests-manage.sh"
# shellcheck source=headless/tests-extras.sh
source "$SCRIPT_DIR/headless/tests-extras.sh"
# shellcheck source=setup.sh
source "$SCRIPT_DIR/setup.sh"
# shellcheck source=../headless/helpers.sh
source "$TESTS_DIR/headless/helpers.sh"
# shellcheck source=tests-create.sh
source "$SCRIPT_DIR/tests-create.sh"
# shellcheck source=tests-manage.sh
source "$SCRIPT_DIR/tests-manage.sh"
# shellcheck source=tests-extras.sh
source "$SCRIPT_DIR/tests-extras.sh"
# Make sure Ctrl+C / SIGTERM / SIGHUP all run the full cleanup path —
# otherwise wnd is nohup'd and keeps running after the script dies,
@@ -10,6 +10,7 @@
set -uo pipefail
SCRIPT_DIR="$(cd -- "$(dirname -- "${BASH_SOURCE[0]}")" && pwd)"
TESTS_DIR="$(cd -- "$SCRIPT_DIR/.." && pwd)"
STATE_DIR="$SCRIPT_DIR/state"
LOG_DIR="$STATE_DIR/logs"
B_DIR="$STATE_DIR/B"
@@ -75,8 +76,8 @@ mkdir -p "$STATE_DIR" "$LOG_DIR" "$B_DIR/logs" "$C_DIR/logs"
: >"$LOG_FILE"
: >"$RESULTS_FILE"
# shellcheck source=lib.sh
source "$SCRIPT_DIR/lib.sh"
# shellcheck source=../lib.sh
source "$TESTS_DIR/lib.sh"
# --- preflight ---------------------------------------------------------------
preflight() {
@@ -1,6 +1,6 @@
# shellcheck shell=bash
#
# headless/setup.sh — preflight + daemon lifecycle + identity bootstrap.
# setup.sh — preflight + daemon lifecycle + identity bootstrap.
# Sourced from marmot-interop-headless.sh.
# --- preflight ---------------------------------------------------------------
@@ -90,7 +90,7 @@ preflight() {
if [[ ! -f "$marker" ]]; then
step "patching whitenoise-rs: $name"
if ( cd "$WN_REPO" && patch -p1 --forward --reject-file=- \
<"$SCRIPT_DIR/headless/patches/$name" >>"$LOG_FILE" 2>&1 ); then
<"$SCRIPT_DIR/patches/$name" >>"$LOG_FILE" 2>&1 ); then
touch "$marker"
# Invalidate the previous build so the patched source is picked up.
rm -f "$WN_BIN" "$WND_BIN"
@@ -170,7 +170,7 @@ description = "Loopback relay for marmot-interop-headless.sh — do not use for
data_directory = "$RELAY_DATA"
[network]
address = "127.0.0.1"
address = "${RELAY_HOST:-127.0.0.1}"
port = $RELAY_PORT
[options]
@@ -198,7 +198,7 @@ EOF
local deadline=$(( $(date +%s) + 20 ))
while [[ $(date +%s) -lt $deadline ]]; do
if curl -sSf -m 1 "http://127.0.0.1:$RELAY_PORT/" >/dev/null 2>&1; then
if curl -sSf -m 1 "http://${RELAY_HOST:-127.0.0.1}:$RELAY_PORT/" >/dev/null 2>&1; then
info "relay up"
return 0
fi
@@ -1,6 +1,6 @@
# shellcheck shell=bash
#
# headless/tests-create.sh — tests 01..05.
# tests-create.sh — tests 01..05.
# Focus: KeyPackage discovery, group creation, invites, initial messages.
test_01_keypackage_discovery() {
@@ -1,6 +1,6 @@
# shellcheck shell=bash
#
# headless/tests-extras.sh — tests 09, 10, 12, 13.
# tests-extras.sh — tests 09, 10, 12, 13.
# Focus: reactions/replies, concurrent commits, offline catchup, KP rotation.
test_09_reply_react_unreact() {
@@ -1,6 +1,6 @@
# shellcheck shell=bash
#
# headless/tests-manage.sh — tests 06, 07, 08, 11.
# tests-manage.sh — tests 06, 07, 08, 11.
# Focus: removal, metadata rename, admin promote/demote, leave.
test_06_member_removal() {
+3
View File
@@ -103,6 +103,9 @@ kotlin {
// Secure key storage via OS keychain (macOS/Windows/Linux)
implementation(libs.java.keyring)
// EXIF stripping for image uploads (used by service/upload/MediaCompressor).
implementation(libs.commons.imaging)
}
}
@@ -20,6 +20,7 @@
*/
package com.vitorpamplona.amethyst.commons.marmot
import com.vitorpamplona.amethyst.commons.relayClient.nip17Dm.unwrapAndUnsealOrNull
import com.vitorpamplona.quartz.marmot.GroupEventResult
import com.vitorpamplona.quartz.marmot.MarmotInboundProcessor
import com.vitorpamplona.quartz.marmot.WelcomeResult
@@ -27,7 +28,6 @@ import com.vitorpamplona.quartz.marmot.mip02Welcome.WelcomeEvent
import com.vitorpamplona.quartz.marmot.mip03GroupMessages.GroupEvent
import com.vitorpamplona.quartz.nip01Core.core.Event
import com.vitorpamplona.quartz.nip01Core.core.HexKey
import com.vitorpamplona.quartz.nip59Giftwrap.seals.SealedRumorEvent
import com.vitorpamplona.quartz.nip59Giftwrap.wraps.GiftWrapEvent
/**
@@ -96,19 +96,12 @@ suspend fun MarmotManager.ingest(event: Event): MarmotIngestResult =
private suspend fun MarmotManager.ingestGiftWrap(wrap: GiftWrapEvent): MarmotIngestResult =
try {
// NIP-59 wraps contain TWO encryption layers:
// kind:1059 gift wrap → kind:13 sealed rumor → the rumor itself.
// `GiftWrapEvent.unwrapOrNull` only peels the outer layer; when the
// result is a [SealedRumorEvent] we must unseal it to reach the
// kind:444 Welcome rumor. The old code checked `isWelcomeEvent` on
// the seal (kind:13) and always took the Ignored branch, which is
// why every inbound Welcome was silently dropped by the CLI and by
// any non-Amethyst consumer.
val rumor =
when (val inner = wrap.unwrapOrNull(signer) ?: return MarmotIngestResult.Ignored) {
is SealedRumorEvent -> inner.unsealOrNull(signer) ?: return MarmotIngestResult.Ignored
else -> inner
}
// NIP-59 wraps carry two encryption layers (kind:1059 → kind:13 → rumor).
// [unwrapAndUnsealOrNull] peels both so we land directly on the inner
// kind:444 Welcome rumor. Checking `isWelcomeEvent` on the seal itself
// (the old bug) always took the Ignored branch and silently dropped
// every inbound Welcome.
val rumor = wrap.unwrapAndUnsealOrNull(signer) ?: return MarmotIngestResult.Ignored
if (!MarmotInboundProcessor.isWelcomeEvent(rumor) || rumor !is WelcomeEvent) {
return MarmotIngestResult.Ignored
}
@@ -18,7 +18,7 @@
* AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
* WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
*/
package com.vitorpamplona.amethyst.service.relayClient.reqCommand.account.nip59GiftWraps
package com.vitorpamplona.amethyst.commons.relayClient.nip17Dm
import com.vitorpamplona.quartz.nip01Core.core.HexKey
import com.vitorpamplona.quartz.nip01Core.relay.client.pool.RelayBasedFilter
@@ -0,0 +1,46 @@
/*
* Copyright (c) 2025 Vitor Pamplona
*
* Permission is hereby granted, free of charge, to any person obtaining a copy of
* this software and associated documentation files (the "Software"), to deal in
* the Software without restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the
* Software, and to permit persons to whom the Software is furnished to do so,
* subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in all
* copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
* FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
* COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN
* AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
* WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
*/
package com.vitorpamplona.amethyst.commons.relayClient.nip17Dm
import com.vitorpamplona.quartz.nip01Core.core.Event
import com.vitorpamplona.quartz.nip01Core.signers.NostrSigner
import com.vitorpamplona.quartz.nip59Giftwrap.seals.SealedRumorEvent
import com.vitorpamplona.quartz.nip59Giftwrap.wraps.GiftWrapEvent
/**
* Fully decrypt a NIP-59 gift wrap down to the inner rumor.
*
* A gift wrap carries two encryption layers:
* kind:1059 [GiftWrapEvent] kind:13 [SealedRumorEvent] the rumor.
*
* [GiftWrapEvent.unwrapOrNull] peels only the outer layer. Every non-Android
* consumer that looks at the rumor directly (the CLI's `dm list`, the desktop
* chat receive path, the Marmot welcome ingest in commons) needs both peels.
*
* If the inner content isn't a [SealedRumorEvent] (malformed, or a future
* NIP-59 variant that wraps a rumor directly), the outer unwrap result is
* returned as-is so callers can still route on kind. Either unwrap returning
* null propagates as null.
*/
suspend fun GiftWrapEvent.unwrapAndUnsealOrNull(signer: NostrSigner): Event? {
val inner = unwrapOrNull(signer) ?: return null
return if (inner is SealedRumorEvent) inner.unsealOrNull(signer) else inner
}
@@ -18,14 +18,14 @@
* AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
* WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
*/
package com.vitorpamplona.amethyst.desktop.service.upload
package com.vitorpamplona.amethyst.commons.service.upload
import com.vitorpamplona.quartz.nip01Core.core.HexKey
import com.vitorpamplona.quartz.nip01Core.signers.NostrSigner
import com.vitorpamplona.quartz.nipB7Blossom.BlossomAuthorizationEvent
import java.util.Base64
object DesktopBlossomAuth {
object BlossomAuth {
suspend fun createUploadAuth(
hash: HexKey,
size: Long,
@@ -18,9 +18,8 @@
* AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
* WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
*/
package com.vitorpamplona.amethyst.desktop.service.upload
package com.vitorpamplona.amethyst.commons.service.upload
import com.vitorpamplona.amethyst.desktop.network.DesktopHttpClient
import com.vitorpamplona.quartz.nip01Core.core.JsonMapper
import com.vitorpamplona.quartz.nipB7Blossom.BlossomUploadResult
import kotlinx.coroutines.Dispatchers
@@ -34,11 +33,16 @@ import okio.BufferedSink
import okio.source
import java.io.File
class DesktopBlossomClient(
private val clientOverride: OkHttpClient? = null,
/**
* Blossom HTTP client for JVM consumers (desktop + CLI). Owns no global
* state pass a configured [OkHttpClient] (e.g. desktop's Tor-aware
* `DesktopHttpClient.currentClient()`) for proxying / connection pooling.
* The default constructor uses a fresh OkHttpClient fine for one-shot
* uses such as the CLI.
*/
class BlossomClient(
private val okHttpClient: OkHttpClient = OkHttpClient(),
) {
private val okHttpClient: OkHttpClient get() = clientOverride ?: DesktopHttpClient.currentClient()
suspend fun upload(
file: File,
contentType: String,
@@ -72,7 +76,8 @@ class DesktopBlossomClient(
val reason = it.headers["X-Reason"] ?: it.code.toString()
throw RuntimeException("Upload failed ($serverBaseUrl): $reason")
}
JsonMapper.fromJson<BlossomUploadResult>(it.body.string())
val body = it.body ?: throw RuntimeException("Upload to $serverBaseUrl returned no body")
JsonMapper.fromJson<BlossomUploadResult>(body.string())
}
}
@@ -103,7 +108,8 @@ class DesktopBlossomClient(
val reason = it.headers["X-Reason"] ?: it.code.toString()
throw RuntimeException("Upload failed ($serverBaseUrl): $reason")
}
JsonMapper.fromJson<BlossomUploadResult>(it.body.string())
val body = it.body ?: throw RuntimeException("Upload to $serverBaseUrl returned no body")
JsonMapper.fromJson<BlossomUploadResult>(body.string())
}
}
}
@@ -18,14 +18,14 @@
* AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
* WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
*/
package com.vitorpamplona.amethyst.desktop.service.upload
package com.vitorpamplona.amethyst.commons.service.upload
import org.apache.commons.imaging.Imaging
import org.apache.commons.imaging.formats.jpeg.exif.ExifRewriter
import java.io.ByteArrayOutputStream
import java.io.File
object DesktopMediaCompressor {
object MediaCompressor {
fun stripExif(file: File): File {
if (!file.name.lowercase().let { it.endsWith(".jpg") || it.endsWith(".jpeg") }) {
return file
@@ -18,7 +18,7 @@
* AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
* WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
*/
package com.vitorpamplona.amethyst.desktop.service.upload
package com.vitorpamplona.amethyst.commons.service.upload
import com.vitorpamplona.amethyst.commons.blurhash.toBlurhash
import com.vitorpamplona.amethyst.commons.blurhash.toPlatformImage
@@ -38,7 +38,12 @@ data class MediaMetadata(
val thumbhash: String? = null,
)
object DesktopMediaMetadata {
/**
* Reads media metadata (sha256, size, mime-type, dimensions, blurhash, thumbhash)
* from a JVM [File]. Named to avoid colliding with the [MediaMetadata] data class
* in the same package.
*/
object MediaMetadataReader {
fun compute(file: File): MediaMetadata {
val bytes = file.readBytes()
val hash = sha256(bytes).toHexKey()
@@ -18,7 +18,7 @@
* AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
* WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
*/
package com.vitorpamplona.amethyst.desktop.service.upload
package com.vitorpamplona.amethyst.commons.service.upload
import com.vitorpamplona.quartz.nip01Core.core.toHexKey
import com.vitorpamplona.quartz.nip01Core.signers.NostrSigner
@@ -39,8 +39,8 @@ data class EncryptedUploadResult(
val encryptedSize: Int,
)
class DesktopUploadOrchestrator(
private val client: DesktopBlossomClient = DesktopBlossomClient(),
class UploadOrchestrator(
private val client: BlossomClient = BlossomClient(),
) {
suspend fun upload(
file: File,
@@ -52,17 +52,17 @@ class DesktopUploadOrchestrator(
// 1. Strip EXIF if requested (JPEG only)
val processedFile =
if (stripExif) {
DesktopMediaCompressor.stripExif(file)
MediaCompressor.stripExif(file)
} else {
file
}
// 2. Compute metadata (hash, dimensions, blurhash)
val metadata = DesktopMediaMetadata.compute(processedFile)
val metadata = MediaMetadataReader.compute(processedFile)
// 3. Create auth header
val authHeader =
DesktopBlossomAuth.createUploadAuth(
BlossomAuth.createUploadAuth(
hash = metadata.sha256,
size = metadata.size,
alt = alt ?: "Uploading ${file.name}",
@@ -98,7 +98,7 @@ class DesktopUploadOrchestrator(
signer: NostrSigner,
): EncryptedUploadResult {
// 1. Compute pre-encryption metadata (dimensions, blurhash, mime, originalHash)
val metadata = DesktopMediaMetadata.compute(file)
val metadata = MediaMetadataReader.compute(file)
// 2. Read file bytes and encrypt
val plaintext = file.readBytes()
@@ -110,7 +110,7 @@ class DesktopUploadOrchestrator(
// 4. Create Blossom auth with encrypted hash and size
val authHeader =
DesktopBlossomAuth.createUploadAuth(
BlossomAuth.createUploadAuth(
hash = encryptedHash,
size = encryptedSize.toLong(),
alt = "Encrypted upload",
@@ -71,6 +71,7 @@ import androidx.compose.ui.window.application
import androidx.compose.ui.window.rememberWindowState
import com.vitorpamplona.amethyst.commons.icons.symbols.Icon
import com.vitorpamplona.amethyst.commons.icons.symbols.MaterialSymbols
import com.vitorpamplona.amethyst.commons.relayClient.nip17Dm.unwrapAndUnsealOrNull
import com.vitorpamplona.amethyst.desktop.account.AccountManager
import com.vitorpamplona.amethyst.desktop.account.AccountState
import com.vitorpamplona.amethyst.desktop.cache.DesktopLocalCache
@@ -1022,13 +1023,9 @@ fun MainContent(
}
is com.vitorpamplona.quartz.nip59Giftwrap.wraps.GiftWrapEvent -> {
// NIP-17: unwrap gift wrap seal → inner event
// NIP-17: peel both the gift-wrap and sealed-rumor layers.
scope.launch {
val seal =
event.unwrapOrNull(iAccount.signer)
as? com.vitorpamplona.quartz.nip59Giftwrap.seals.SealedRumorEvent
?: return@launch
val innerEvent = seal.unsealOrNull(iAccount.signer) ?: return@launch
val innerEvent = event.unwrapAndUnsealOrNull(iAccount.signer) ?: return@launch
when (innerEvent) {
is com.vitorpamplona.quartz.nip17Dm.messages.ChatMessageEvent -> {
val innerNote = localCache.getOrCreateNote(innerEvent.id)
@@ -20,6 +20,7 @@
*/
package com.vitorpamplona.amethyst.desktop.service.upload
import com.vitorpamplona.amethyst.commons.service.upload.UploadResult
import kotlinx.coroutines.flow.MutableStateFlow
import kotlinx.coroutines.flow.asStateFlow
@@ -51,12 +51,12 @@ import androidx.compose.ui.draganddrop.DragAndDropEvent
import androidx.compose.ui.draganddrop.DragAndDropTarget
import androidx.compose.ui.unit.dp
import androidx.compose.ui.window.Dialog
import com.vitorpamplona.amethyst.commons.service.upload.UploadOrchestrator
import com.vitorpamplona.amethyst.commons.service.upload.UploadResult
import com.vitorpamplona.amethyst.desktop.DesktopPreferences
import com.vitorpamplona.amethyst.desktop.account.AccountState
import com.vitorpamplona.amethyst.desktop.network.DesktopRelayConnectionManager
import com.vitorpamplona.amethyst.desktop.service.upload.DesktopUploadOrchestrator
import com.vitorpamplona.amethyst.desktop.service.upload.DesktopUploadTracker
import com.vitorpamplona.amethyst.desktop.service.upload.UploadResult
import com.vitorpamplona.amethyst.desktop.ui.compose.ComposeRelayPicker
import com.vitorpamplona.amethyst.desktop.ui.compose.RelayPickerState
import com.vitorpamplona.amethyst.desktop.ui.media.ClipboardPasteHandler
@@ -103,7 +103,7 @@ fun ComposeNoteDialog(
val attachedFiles = remember { mutableStateListOf<File>() }
val uploadTracker = remember { DesktopUploadTracker() }
val uploadState by uploadTracker.state.collectAsState()
val orchestrator = remember { DesktopUploadOrchestrator() }
val orchestrator = remember { UploadOrchestrator() }
var selectedServer by remember { mutableStateOf(DesktopPreferences.preferredBlossomServer) }
var postAsPicture by remember { mutableStateOf(false) }
@@ -482,11 +482,11 @@ private fun buildPictureMetas(results: List<UploadResult>): List<com.vitorpamplo
mimeType = meta.mimeType,
blurhash = meta.blurhash,
dimension =
if (meta.width != null && meta.height != null) {
meta.width?.let { w ->
meta.height?.let { h ->
com.vitorpamplona.quartz.nip94FileMetadata.tags
.DimensionTag(meta.width, meta.height)
} else {
null
.DimensionTag(w, h)
}
},
hash = meta.sha256,
size = meta.size.toInt(),
@@ -81,6 +81,7 @@ import com.vitorpamplona.amethyst.commons.icons.symbols.MaterialSymbols
import com.vitorpamplona.amethyst.commons.model.IAccount
import com.vitorpamplona.amethyst.commons.model.Note
import com.vitorpamplona.amethyst.commons.model.cache.ICacheProvider
import com.vitorpamplona.amethyst.commons.service.upload.UploadOrchestrator
import com.vitorpamplona.amethyst.commons.ui.chat.ChatMessageCompose
import com.vitorpamplona.amethyst.commons.ui.chat.ChatroomHeader
import com.vitorpamplona.amethyst.commons.ui.chat.DmBroadcastBanner
@@ -92,7 +93,6 @@ import com.vitorpamplona.amethyst.commons.util.toTimeAgo
import com.vitorpamplona.amethyst.commons.viewmodels.ChatNewMessageState
import com.vitorpamplona.amethyst.commons.viewmodels.ChatroomFeedViewModel
import com.vitorpamplona.amethyst.desktop.DesktopPreferences
import com.vitorpamplona.amethyst.desktop.service.upload.DesktopUploadOrchestrator
import com.vitorpamplona.amethyst.desktop.ui.media.DesktopFilePicker
import com.vitorpamplona.amethyst.desktop.ui.media.MediaAttachmentRow
import com.vitorpamplona.quartz.nip01Core.hints.EventHintBundle
@@ -796,7 +796,7 @@ private suspend fun sendEncryptedFiles(
account: IAccount,
cacheProvider: ICacheProvider,
) {
val orchestrator = DesktopUploadOrchestrator()
val orchestrator = UploadOrchestrator()
val server = DesktopPreferences.preferredBlossomServer
val recipients = roomKey.users.mapNotNull { cacheProvider.getUserIfExists(it) }.map { it.toPTag() }
@@ -814,10 +814,8 @@ private suspend fun sendEncryptedFiles(
hash = result.encryptedHash,
size = result.encryptedSize,
dimension =
if (result.metadata.width != null && result.metadata.height != null) {
DimensionTag(result.metadata.width, result.metadata.height)
} else {
null
result.metadata.width?.let { w ->
result.metadata.height?.let { h -> DimensionTag(w, h) }
},
blurhash = result.metadata.blurhash,
thumbhash = result.metadata.thumbhash,
@@ -37,7 +37,7 @@ import kotlin.test.assertEquals
import kotlin.test.assertFailsWith
import kotlin.test.assertTrue
class DesktopBlossomClientTest {
class BlossomClientTest {
private fun mockOkHttp(
responseCode: Int,
body: String = "",
@@ -67,7 +67,7 @@ class DesktopBlossomClientTest {
runTest {
val json =
"""{"url":"https://blossom.example.com/abc123.png","sha256":"abc123","size":1024}"""
val client = DesktopBlossomClient(mockOkHttp(200, json))
val client = BlossomClient(mockOkHttp(200, json))
val file = File.createTempFile("test_", ".png")
file.deleteOnExit()
@@ -94,7 +94,7 @@ class DesktopBlossomClientTest {
fun uploadFailureThrowsException() =
runTest {
val headers = Headers.headersOf("X-Reason", "File too large")
val client = DesktopBlossomClient(mockOkHttp(413, "", headers))
val client = BlossomClient(mockOkHttp(413, "", headers))
val file = File.createTempFile("test_", ".png")
file.deleteOnExit()
@@ -119,7 +119,7 @@ class DesktopBlossomClientTest {
@Test
fun uploadFailureUsesStatusCodeWhenNoXReason() =
runTest {
val client = DesktopBlossomClient(mockOkHttp(500))
val client = BlossomClient(mockOkHttp(500))
val file = File.createTempFile("test_", ".png")
file.deleteOnExit()
@@ -159,7 +159,7 @@ class DesktopBlossomClientTest {
.body("""{"url":"https://example.com/hash"}""".toResponseBody())
.build()
val client = DesktopBlossomClient(mockClient)
val client = BlossomClient(mockClient)
val file = File.createTempFile("test_", ".png")
file.deleteOnExit()
file.writeBytes(byteArrayOf(1))
@@ -199,7 +199,7 @@ class DesktopBlossomClientTest {
.body("""{"url":"https://example.com/hash"}""".toResponseBody())
.build()
val client = DesktopBlossomClient(mockClient)
val client = BlossomClient(mockClient)
val file = File.createTempFile("test_", ".png")
file.deleteOnExit()
file.writeBytes(byteArrayOf(1))
@@ -20,6 +20,8 @@
*/
package com.vitorpamplona.amethyst.desktop.service.upload
import com.vitorpamplona.amethyst.commons.service.upload.MediaMetadata
import com.vitorpamplona.amethyst.commons.service.upload.UploadResult
import com.vitorpamplona.quartz.nipB7Blossom.BlossomUploadResult
import kotlinx.coroutines.flow.first
import kotlinx.coroutines.test.runTest
@@ -27,7 +27,7 @@ import kotlin.test.Test
import kotlin.test.assertEquals
import kotlin.test.assertTrue
class DesktopMediaCompressorTest {
class MediaCompressorTest {
@Test
fun stripExifReturnsSameFileForPng() {
val file = File.createTempFile("test_", ".png")
@@ -35,7 +35,7 @@ class DesktopMediaCompressorTest {
val img = BufferedImage(2, 2, BufferedImage.TYPE_INT_RGB)
ImageIO.write(img, "png", file)
val result = DesktopMediaCompressor.stripExif(file)
val result = MediaCompressor.stripExif(file)
// Should return the same file object since it's not JPEG
assertEquals(file, result)
@@ -48,7 +48,7 @@ class DesktopMediaCompressorTest {
file.deleteOnExit()
file.writeText("not a jpeg")
val result = DesktopMediaCompressor.stripExif(file)
val result = MediaCompressor.stripExif(file)
assertEquals(file, result)
file.delete()
@@ -60,7 +60,7 @@ class DesktopMediaCompressorTest {
file.deleteOnExit()
file.writeBytes(byteArrayOf(0, 0, 0))
val result = DesktopMediaCompressor.stripExif(file)
val result = MediaCompressor.stripExif(file)
assertEquals(file, result)
file.delete()
@@ -71,7 +71,7 @@ class DesktopMediaCompressorTest {
// Create a minimal JPEG without EXIF
val file = createMinimalJpeg()
try {
val result = DesktopMediaCompressor.stripExif(file)
val result = MediaCompressor.stripExif(file)
// Should return the same file since there's no EXIF to strip
assertEquals(file, result)
} finally {
@@ -87,7 +87,7 @@ class DesktopMediaCompressorTest {
val img = BufferedImage(4, 4, BufferedImage.TYPE_INT_RGB)
ImageIO.write(img, "jpg", file)
val result = DesktopMediaCompressor.stripExif(file)
val result = MediaCompressor.stripExif(file)
// Result should be a valid file regardless
assertTrue(result.exists())
@@ -107,7 +107,7 @@ class DesktopMediaCompressorTest {
val img = BufferedImage(2, 2, BufferedImage.TYPE_INT_RGB)
ImageIO.write(img, "jpg", file)
val result = DesktopMediaCompressor.stripExif(file)
val result = MediaCompressor.stripExif(file)
assertTrue(result.exists())
if (result != file) result.delete()
@@ -29,60 +29,60 @@ import kotlin.test.assertNotNull
import kotlin.test.assertNull
import kotlin.test.assertTrue
class DesktopMediaMetadataTest {
class MediaMetadataReaderTest {
// --- guessMimeType ---
@Test
fun guessMimeTypeForJpeg() {
assertEquals("image/jpeg", DesktopMediaMetadata.guessMimeType(File("photo.jpg")))
assertEquals("image/jpeg", DesktopMediaMetadata.guessMimeType(File("photo.jpeg")))
assertEquals("image/jpeg", DesktopMediaMetadata.guessMimeType(File("photo.JPEG")))
assertEquals("image/jpeg", MediaMetadataReader.guessMimeType(File("photo.jpg")))
assertEquals("image/jpeg", MediaMetadataReader.guessMimeType(File("photo.jpeg")))
assertEquals("image/jpeg", MediaMetadataReader.guessMimeType(File("photo.JPEG")))
}
@Test
fun guessMimeTypeForPng() {
assertEquals("image/png", DesktopMediaMetadata.guessMimeType(File("image.png")))
assertEquals("image/png", MediaMetadataReader.guessMimeType(File("image.png")))
}
@Test
fun guessMimeTypeForGif() {
assertEquals("image/gif", DesktopMediaMetadata.guessMimeType(File("anim.gif")))
assertEquals("image/gif", MediaMetadataReader.guessMimeType(File("anim.gif")))
}
@Test
fun guessMimeTypeForWebp() {
assertEquals("image/webp", DesktopMediaMetadata.guessMimeType(File("image.webp")))
assertEquals("image/webp", MediaMetadataReader.guessMimeType(File("image.webp")))
}
@Test
fun guessMimeTypeForSvg() {
assertEquals("image/svg+xml", DesktopMediaMetadata.guessMimeType(File("icon.svg")))
assertEquals("image/svg+xml", MediaMetadataReader.guessMimeType(File("icon.svg")))
}
@Test
fun guessMimeTypeForAvif() {
assertEquals("image/avif", DesktopMediaMetadata.guessMimeType(File("photo.avif")))
assertEquals("image/avif", MediaMetadataReader.guessMimeType(File("photo.avif")))
}
@Test
fun guessMimeTypeForVideoFormats() {
assertEquals("video/mp4", DesktopMediaMetadata.guessMimeType(File("clip.mp4")))
assertEquals("video/webm", DesktopMediaMetadata.guessMimeType(File("clip.webm")))
assertEquals("video/quicktime", DesktopMediaMetadata.guessMimeType(File("clip.mov")))
assertEquals("video/mp4", MediaMetadataReader.guessMimeType(File("clip.mp4")))
assertEquals("video/webm", MediaMetadataReader.guessMimeType(File("clip.webm")))
assertEquals("video/quicktime", MediaMetadataReader.guessMimeType(File("clip.mov")))
}
@Test
fun guessMimeTypeForAudioFormats() {
assertEquals("audio/mpeg", DesktopMediaMetadata.guessMimeType(File("song.mp3")))
assertEquals("audio/ogg", DesktopMediaMetadata.guessMimeType(File("track.ogg")))
assertEquals("audio/wav", DesktopMediaMetadata.guessMimeType(File("sound.wav")))
assertEquals("audio/flac", DesktopMediaMetadata.guessMimeType(File("lossless.flac")))
assertEquals("audio/mpeg", MediaMetadataReader.guessMimeType(File("song.mp3")))
assertEquals("audio/ogg", MediaMetadataReader.guessMimeType(File("track.ogg")))
assertEquals("audio/wav", MediaMetadataReader.guessMimeType(File("sound.wav")))
assertEquals("audio/flac", MediaMetadataReader.guessMimeType(File("lossless.flac")))
}
@Test
fun guessMimeTypeForUnknownExtension() {
assertEquals("application/octet-stream", DesktopMediaMetadata.guessMimeType(File("data.xyz")))
assertEquals("application/octet-stream", DesktopMediaMetadata.guessMimeType(File("noext")))
assertEquals("application/octet-stream", MediaMetadataReader.guessMimeType(File("data.xyz")))
assertEquals("application/octet-stream", MediaMetadataReader.guessMimeType(File("noext")))
}
// --- compute ---
@@ -91,7 +91,7 @@ class DesktopMediaMetadataTest {
fun computeForPngImage() {
val file = createTempPng(width = 10, height = 5)
try {
val meta = DesktopMediaMetadata.compute(file)
val meta = MediaMetadataReader.compute(file)
assertEquals("image/png", meta.mimeType)
assertTrue(meta.size > 0)
@@ -110,7 +110,7 @@ class DesktopMediaMetadataTest {
file.deleteOnExit()
file.writeText("hello world")
try {
val meta = DesktopMediaMetadata.compute(file)
val meta = MediaMetadataReader.compute(file)
assertEquals("application/octet-stream", meta.mimeType)
assertEquals(11L, meta.size)
@@ -129,8 +129,8 @@ class DesktopMediaMetadataTest {
file.deleteOnExit()
file.writeBytes(byteArrayOf(1, 2, 3, 4, 5))
try {
val meta1 = DesktopMediaMetadata.compute(file)
val meta2 = DesktopMediaMetadata.compute(file)
val meta1 = MediaMetadataReader.compute(file)
val meta2 = MediaMetadataReader.compute(file)
assertEquals(meta1.sha256, meta2.sha256)
} finally {
file.delete()
@@ -143,7 +143,7 @@ class DesktopMediaMetadataTest {
file.deleteOnExit()
file.writeBytes(byteArrayOf(0, 0, 0))
try {
val meta = DesktopMediaMetadata.compute(file)
val meta = MediaMetadataReader.compute(file)
assertEquals("video/mp4", meta.mimeType)
assertNull(meta.width)
assertNull(meta.height)
@@ -36,24 +36,24 @@ import kotlin.test.assertEquals
import kotlin.test.assertNotNull
import kotlin.test.assertTrue
class DesktopUploadOrchestratorTest {
class UploadOrchestratorTest {
@BeforeTest
fun setup() {
mockkObject(DesktopBlossomAuth)
mockkObject(BlossomAuth)
coEvery {
DesktopBlossomAuth.createUploadAuth(any(), any(), any(), any())
BlossomAuth.createUploadAuth(any(), any(), any(), any())
} returns "Nostr fakeAuthToken"
}
@AfterTest
fun teardown() {
unmockkObject(DesktopBlossomAuth)
unmockkObject(BlossomAuth)
}
@Test
fun uploadCallsClientWithCorrectParameters() =
runTest {
val mockClient = mockk<DesktopBlossomClient>()
val mockClient = mockk<BlossomClient>()
val fileSlot = slot<File>()
val contentTypeSlot = slot<String>()
val urlSlot = slot<String>()
@@ -72,7 +72,7 @@ class DesktopUploadOrchestratorTest {
size = 100,
)
val orchestrator = DesktopUploadOrchestrator(mockClient)
val orchestrator = UploadOrchestrator(mockClient)
val file = File.createTempFile("test_", ".png")
file.deleteOnExit()
@@ -112,7 +112,7 @@ class DesktopUploadOrchestratorTest {
@Test
fun uploadPassesSameFileWhenNoStripExif() =
runTest {
val mockClient = mockk<DesktopBlossomClient>()
val mockClient = mockk<BlossomClient>()
val fileSlot = slot<File>()
coEvery {
@@ -124,7 +124,7 @@ class DesktopUploadOrchestratorTest {
)
} returns BlossomUploadResult(url = "https://example.com/hash")
val orchestrator = DesktopUploadOrchestrator(mockClient)
val orchestrator = UploadOrchestrator(mockClient)
val file = File.createTempFile("test_", ".txt")
file.deleteOnExit()
@@ -150,13 +150,13 @@ class DesktopUploadOrchestratorTest {
@Test
fun uploadComputesMetadata() =
runTest {
val mockClient = mockk<DesktopBlossomClient>()
val mockClient = mockk<BlossomClient>()
coEvery {
mockClient.upload(any<java.io.File>(), any<String>(), any<String>(), any())
} returns BlossomUploadResult(url = "https://example.com/hash")
val orchestrator = DesktopUploadOrchestrator(mockClient)
val orchestrator = UploadOrchestrator(mockClient)
val file = File.createTempFile("test_", ".txt")
file.deleteOnExit()
@@ -185,7 +185,7 @@ class DesktopUploadOrchestratorTest {
@Test
fun uploadPassesAuthHeaderToClient() =
runTest {
val mockClient = mockk<DesktopBlossomClient>()
val mockClient = mockk<BlossomClient>()
val authSlot = slot<String?>()
coEvery {
@@ -197,7 +197,7 @@ class DesktopUploadOrchestratorTest {
)
} returns BlossomUploadResult(url = "https://example.com/hash")
val orchestrator = DesktopUploadOrchestrator(mockClient)
val orchestrator = UploadOrchestrator(mockClient)
val file = File.createTempFile("test_", ".txt")
file.deleteOnExit()
-2
View File
@@ -1,2 +0,0 @@
state/
state-headless/