From daebea262a9b77249764ae207fe281f111562220 Mon Sep 17 00:00:00 2001
From: davotoula <david.kaspar@gmail.com>
Date: Mon, 2 Mar 2026 16:56:28 +0000
Subject: [PATCH] add user avatar content descriptions in shared components

---
 commons/src/commonMain/composeResources/values/strings.xml   | 3 +++
 .../vitorpamplona/amethyst/commons/ui/chat/ChatroomHeader.kt | 5 +++++
 .../amethyst/commons/ui/components/UserSearchCard.kt         | 5 ++++-
 3 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/commons/src/commonMain/composeResources/values/strings.xml b/commons/src/commonMain/composeResources/values/strings.xml
index 7403080ba..2ba92eb3b 100644
--- a/commons/src/commonMain/composeResources/values/strings.xml
+++ b/commons/src/commonMain/composeResources/values/strings.xml
@@ -50,4 +50,7 @@
     <string name="screen_messages_description">Your encrypted direct messages will appear here.</string>
     <string name="screen_notifications_title">Notifications</string>
     <string name="screen_notifications_description">Mentions, replies, and reactions will appear here.</string>
+
+    <!-- Accessibility -->
+    <string name="accessibility_user_avatar">User avatar</string>
 </resources>
diff --git a/commons/src/commonMain/kotlin/com/vitorpamplona/amethyst/commons/ui/chat/ChatroomHeader.kt b/commons/src/commonMain/kotlin/com/vitorpamplona/amethyst/commons/ui/chat/ChatroomHeader.kt
index df25cb8c7..021b7530f 100644
--- a/commons/src/commonMain/kotlin/com/vitorpamplona/amethyst/commons/ui/chat/ChatroomHeader.kt
+++ b/commons/src/commonMain/kotlin/com/vitorpamplona/amethyst/commons/ui/chat/ChatroomHeader.kt
@@ -35,9 +35,12 @@ import androidx.compose.ui.text.font.FontWeight
 import androidx.compose.ui.text.style.TextOverflow
 import androidx.compose.ui.unit.dp
 import com.vitorpamplona.amethyst.commons.model.User
+import com.vitorpamplona.amethyst.commons.resources.Res
+import com.vitorpamplona.amethyst.commons.resources.accessibility_user_avatar
 import com.vitorpamplona.amethyst.commons.ui.components.UserAvatar
 import com.vitorpamplona.amethyst.commons.ui.theme.ChatSize34dp
 import com.vitorpamplona.amethyst.commons.ui.theme.ChatStdPadding
+import org.jetbrains.compose.resources.stringResource
 
 /**
  * Shared chatroom header for a single-user conversation.
@@ -67,6 +70,7 @@ fun ChatroomHeader(
                     userHex = user.pubkeyHex,
                     pictureUrl = user.profilePicture(),
                     size = ChatSize34dp,
+                    contentDescription = stringResource(Res.string.accessibility_user_avatar),
                 )
 
                 Column(modifier = Modifier.padding(start = 10.dp)) {
@@ -114,6 +118,7 @@ fun GroupChatroomHeader(
                         userHex = firstUser.pubkeyHex,
                         pictureUrl = firstUser.profilePicture(),
                         size = ChatSize34dp,
+                        contentDescription = stringResource(Res.string.accessibility_user_avatar),
                     )
                 }
 
diff --git a/commons/src/commonMain/kotlin/com/vitorpamplona/amethyst/commons/ui/components/UserSearchCard.kt b/commons/src/commonMain/kotlin/com/vitorpamplona/amethyst/commons/ui/components/UserSearchCard.kt
index eb2b0d51d..2092ebd63 100644
--- a/commons/src/commonMain/kotlin/com/vitorpamplona/amethyst/commons/ui/components/UserSearchCard.kt
+++ b/commons/src/commonMain/kotlin/com/vitorpamplona/amethyst/commons/ui/components/UserSearchCard.kt
@@ -39,6 +39,9 @@ import androidx.compose.ui.Modifier
 import androidx.compose.ui.text.font.FontFamily
 import androidx.compose.ui.unit.dp
 import com.vitorpamplona.amethyst.commons.model.User
+import com.vitorpamplona.amethyst.commons.resources.Res
+import com.vitorpamplona.amethyst.commons.resources.accessibility_user_avatar
+import org.jetbrains.compose.resources.stringResource
 
 /**
  * A card displaying user search result with avatar, name, and nip05/pubkey.
@@ -69,7 +72,7 @@ fun UserSearchCard(
                 userHex = user.pubkeyHex,
                 pictureUrl = user.profilePicture(),
                 size = 40.dp,
-                contentDescription = "Profile picture",
+                contentDescription = stringResource(Res.string.accessibility_user_avatar),
             )
 
             Column(modifier = Modifier.weight(1f)) {