Seeing if the performance improves when the factory becomes just another lambda

This commit is contained in:
Vitor Pamplona
2024-03-18 16:23:00 -04:00
parent d83acab84b
commit f5a1007f88
2 changed files with 33 additions and 40 deletions
@@ -669,9 +669,20 @@ private fun RenderVideoPlayer(
} }
} }
val factory = val ratio = remember { aspectRatio(dimensions) }
remember(controller) {
{ context: Context -> if (ratio != null) {
DisplayBlurHash(
blurhash,
null,
ContentScale.Crop,
myModifier.aspectRatio(ratio),
)
}
AndroidView(
modifier = myModifier,
factory = { context: Context ->
PlayerView(context).apply { PlayerView(context).apply {
player = controller player = controller
layoutParams = layoutParams =
@@ -703,23 +714,7 @@ private fun RenderVideoPlayer(
}, },
) )
} }
} },
}
val ratio = remember { aspectRatio(dimensions) }
if (ratio != null) {
DisplayBlurHash(
blurhash,
null,
ContentScale.Crop,
myModifier.aspectRatio(ratio),
)
}
AndroidView(
modifier = myModifier,
factory = factory,
) )
waveform?.let { Waveform(it, controller, remember { Modifier.align(Alignment.Center) }) } waveform?.let { Waveform(it, controller, remember { Modifier.align(Alignment.Center) }) }
@@ -36,7 +36,6 @@ import androidx.compose.foundation.lazy.itemsIndexed
import androidx.compose.foundation.lazy.rememberLazyListState import androidx.compose.foundation.lazy.rememberLazyListState
import androidx.compose.foundation.shape.RoundedCornerShape import androidx.compose.foundation.shape.RoundedCornerShape
import androidx.compose.foundation.text.KeyboardOptions import androidx.compose.foundation.text.KeyboardOptions
import androidx.compose.material3.ExperimentalMaterial3Api
import androidx.compose.material3.HorizontalDivider import androidx.compose.material3.HorizontalDivider
import androidx.compose.material3.IconButton import androidx.compose.material3.IconButton
import androidx.compose.material3.MaterialTheme import androidx.compose.material3.MaterialTheme
@@ -290,7 +289,6 @@ private fun SearchBar(
} }
} }
@OptIn(ExperimentalMaterial3Api::class)
@Composable @Composable
private fun SearchTextField( private fun SearchTextField(
searchBarViewModel: SearchBarViewModel, searchBarViewModel: SearchBarViewModel,