From f2d007f9ba3bbfdf04b74b9154cdaf63f2fa984c Mon Sep 17 00:00:00 2001
From: greenart7c3 <greenart7c3@proton.me>
Date: Mon, 30 Mar 2026 17:09:59 -0300
Subject: [PATCH] fix: support external signers wrapped in
 NostrSignerWithClientTag

The external signer registration logic was failing when the signer was
wrapped in a `NostrSignerWithClientTag`. Fix by:

1. Updating `ListenToExternalSignerIfNeeded` to unwrap the signer if it's
   a `NostrSignerWithClientTag` containing an `IActivityLauncher`
2. Using the unwrapped launcher for intent registration and response handling
3. Renaming the intent callback to `intentLauncher` to avoid shadowing the `ActivityResultLauncher` variable
---
 .../ui/screen/loggedIn/LoggedInPage.kt        | 26 +++++++++++++++----
 1 file changed, 21 insertions(+), 5 deletions(-)

diff --git a/amethyst/src/main/java/com/vitorpamplona/amethyst/ui/screen/loggedIn/LoggedInPage.kt b/amethyst/src/main/java/com/vitorpamplona/amethyst/ui/screen/loggedIn/LoggedInPage.kt
index 2fef9419e..7b842cae1 100644
--- a/amethyst/src/main/java/com/vitorpamplona/amethyst/ui/screen/loggedIn/LoggedInPage.kt
+++ b/amethyst/src/main/java/com/vitorpamplona/amethyst/ui/screen/loggedIn/LoggedInPage.kt
@@ -53,6 +53,7 @@ import com.vitorpamplona.amethyst.ui.screen.loggedIn.discover.datasource.Discove
 import com.vitorpamplona.amethyst.ui.screen.loggedIn.home.datasource.HomeFilterAssemblerSubscription
 import com.vitorpamplona.amethyst.ui.screen.loggedIn.video.datasource.VideoFilterAssemblerSubscription
 import com.vitorpamplona.quartz.nip55AndroidSigner.client.IActivityLauncher
+import com.vitorpamplona.quartz.nip89AppHandlers.clientTag.NostrSignerWithClientTag
 import com.vitorpamplona.quartz.utils.Log
 import kotlinx.coroutines.launch
 
@@ -165,7 +166,22 @@ fun NotificationRegistration(accountViewModel: AccountViewModel) {
 
 @Composable
 private fun ListenToExternalSignerIfNeeded(accountViewModel: AccountViewModel) {
-    if (accountViewModel.account.signer is IActivityLauncher) {
+    val externalSignerLauncher =
+        when (val signer = accountViewModel.account.signer) {
+            is IActivityLauncher -> {
+                signer
+            }
+
+            is NostrSignerWithClientTag if signer.inner is IActivityLauncher -> {
+                signer.inner as IActivityLauncher
+            }
+
+            else -> {
+                null
+            }
+        }
+
+    if (externalSignerLauncher != null) {
         val launcher =
             rememberLauncherForActivityResult(
                 contract = ActivityResultContracts.StartActivityForResult(),
@@ -173,7 +189,7 @@ private fun ListenToExternalSignerIfNeeded(accountViewModel: AccountViewModel) {
                     if (result.resultCode == Activity.RESULT_OK) {
                         result.data?.let {
                             accountViewModel.runOnIO {
-                                accountViewModel.account.signer.newResponse(it)
+                                externalSignerLauncher.newResponse(it)
                             }
                         }
                     }
@@ -181,7 +197,7 @@ private fun ListenToExternalSignerIfNeeded(accountViewModel: AccountViewModel) {
             )
 
         DisposableEffect(accountViewModel, accountViewModel.account, launcher) {
-            val launcher: (Intent) -> Unit = { intent ->
+            val intentLauncher: (Intent) -> Unit = { intent ->
                 try {
                     launcher.launch(intent)
                 } catch (e: ActivityNotFoundException) {
@@ -193,9 +209,9 @@ private fun ListenToExternalSignerIfNeeded(accountViewModel: AccountViewModel) {
                 }
             }
 
-            accountViewModel.account.signer.registerForegroundLauncher(launcher)
+            externalSignerLauncher.registerForegroundLauncher(intentLauncher)
             onDispose {
-                accountViewModel.account.signer.unregisterForegroundLauncher(launcher)
+                externalSignerLauncher.unregisterForegroundLauncher(intentLauncher)
             }
         }
     }