nick/amethyst
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

test(nests-interop): revert hot-swap browser to soft-pass per plan Risk § option (a)

Browse Source 
Follow-up to commit `029329af`: a verification sweep (5×) showed
the `pcm.size > warmupSamples` hard floor on
`chromium_listener_speaker_hot_swap_does_not_crash` flakes 3/5 —
empirical capture varies 2880–7680 samples (= 60–160 ms TOTAL),
straddling the 4800-sample warmup threshold. The browser-side
@moq/lite 0.2.x re-attach behaviour across `Active::Ended →
Active` is fundamentally unreliable; ANY hard floor that
excludes the regression mode ("swap killed the WT session
entirely") fail-flakes because the steady state itself sits
right at that threshold.

Per `2026-05-07-tighten-cross-stack-assertions.md`'s Risk § option
(a) — "If any scenario fail-flakes after tightening, [...] revert
the tightening on that scenario" — this commit reverts the
hot-swap floor to a documented soft-pass that prints to
System.err when triggered. T12 (group sequence carry across
hot-swaps) is still asserted by the hang-tier counterpart
(`speaker_hot_swap_does_not_crash` in `HangInteropTest`), which
hard-asserts the full post-swap window decodes the 440 Hz peak.

The deferred "browser hot-swap re-attach" follow-up in
`2026-05-06-cross-stack-interop-test-results.md` captures the
underlying @moq/lite client work that would let this scenario
become a hard-floor test in the future.
This commit is contained in:
Claude
2026-05-07 22:03:38 +00:00
parent 21947bc584
commit f8dc9c59be
2 changed files with 38 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files
nestsClient/plans/2026-05-07-tighten-cross-stack-assertions.md
+1 -1
View File
@@ -111,7 +111,7 @@ hard floors on both tiers.
| **I2 late-join** | `≥ 1.5 s after warmup` | per plan recommendation |
| **I3 mute-window** | lower `≥ 2.5 s` + upper `< 5.5 s` | upper bound left at 5.5 s; the plan's 5.0 s tightening tripped 5/5 against empirical 5.1–5.2 s steady state |
| **I4 stereo** | `≥ 1 s × 2 ch` | new floor (was vacuous) |
| **I5 hot-swap** | `pcm.size > warmupSamples` | weaker than plan's 0.5 s — Chromium's `@moq/lite` 0.2.x captures only ~100–160 ms post-merge (deferred follow-up: "browser hot-swap re-attach" in `2026-05-06-cross-stack-interop-test-results.md`) |
| **I5 hot-swap** | **soft-pass kept** | The `pcm.size > warmupSamples` floor flaked 3/5 in a follow-up sweep — empirical samples vary 0–7.7 k right at the warmup threshold. Reverted to a soft-pass with the printed-to-stderr explanation; T12 protection is asserted by the hang-tier counterpart. Tracked as deferred follow-up "browser hot-swap re-attach" in `2026-05-06-cross-stack-interop-test-results.md`. |
| **I9 packet-loss** | `≥ 0.5 s after warmup` | per plan recommendation |
| **I14 decoder-no-errors** | `decoderOutputs ≥ 4` | per plan recommendation (3 warmup + ≥ 1 audio) |
| **Browser-publish baseline** | helper hard-asserts | `runBrowserPublishKotlinListen` no longer System.err-prints + returns; uses caller-supplied floor |