From f9c7e3b15c31b782c800d1330d4023cc1de64701 Mon Sep 17 00:00:00 2001 From: davotoula Date: Sun, 5 Apr 2026 18:05:48 +0200 Subject: [PATCH] =?UTF-8?q?-=20Added=20@VisibleForTesting=20annotation=20t?= =?UTF-8?q?o=20the=20three=20internal=20methods=20in=20ShareHelper.kt=20?= =?UTF-8?q?=E2=80=94=20signals=20test-only=20intent=20and=20triggers=20lin?= =?UTF-8?q?t=20warnings=20if=20called=20from=20production=20code=20-=20Rem?= =?UTF-8?q?oved=20redundant=20deleteOnExit()=20in=20test=20helper=20?= =?UTF-8?q?=E2=80=94=20explicit=20delete()=20after=20each=20test=20already?= =?UTF-8?q?=20handles=20cleanup;=20the=20shutdown=20hook=20was=20unnecessa?= =?UTF-8?q?ry=20overhead?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../com/vitorpamplona/amethyst/ui/components/ShareHelper.kt | 4 ++++ .../vitorpamplona/amethyst/ui/components/ShareHelperTest.kt | 1 - 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/amethyst/src/main/java/com/vitorpamplona/amethyst/ui/components/ShareHelper.kt b/amethyst/src/main/java/com/vitorpamplona/amethyst/ui/components/ShareHelper.kt index 4be867651..02592b6a0 100644 --- a/amethyst/src/main/java/com/vitorpamplona/amethyst/ui/components/ShareHelper.kt +++ b/amethyst/src/main/java/com/vitorpamplona/amethyst/ui/components/ShareHelper.kt @@ -22,6 +22,7 @@ package com.vitorpamplona.amethyst.ui.components import android.content.Context import android.net.Uri +import androidx.annotation.VisibleForTesting import androidx.core.content.FileProvider import com.vitorpamplona.amethyst.Amethyst import com.vitorpamplona.quartz.utils.Log @@ -85,10 +86,13 @@ object ShareHelper { } ?: throw IOException("Unable to open snapshot for: $imageUrl") } + @VisibleForTesting internal fun getImageExtension(file: File): String = getMediaExtension(file, isVideo = false) + @VisibleForTesting internal fun getVideoExtension(file: File): String = getMediaExtension(file, isVideo = true) + @VisibleForTesting internal fun getMediaExtension( file: File, isVideo: Boolean, diff --git a/amethyst/src/test/java/com/vitorpamplona/amethyst/ui/components/ShareHelperTest.kt b/amethyst/src/test/java/com/vitorpamplona/amethyst/ui/components/ShareHelperTest.kt index e86d33789..8bbc8a29a 100644 --- a/amethyst/src/test/java/com/vitorpamplona/amethyst/ui/components/ShareHelperTest.kt +++ b/amethyst/src/test/java/com/vitorpamplona/amethyst/ui/components/ShareHelperTest.kt @@ -159,7 +159,6 @@ class ShareHelperTest { private fun createTempFileWithBytes(bytes: ByteArray): File { val file = File.createTempFile("sharehelpertest", ".tmp") - file.deleteOnExit() file.writeBytes(bytes) return file }