Claude
9cd8d0a6ee
The qlog confirmed the writer emits 1 STREAM frame per packet on the
live wire, while MultiplexingCoalescingTest + MultiplexingAioquicTpsTest
both show ~9 streams per packet under synchronous drain. So the bug is
in the live driver flow — concurrent send loop + parser feed +
real-socket interleaving — and not in buildApplicationPacket itself.
To localize: add an opt-in trace at the END of buildApplicationPacket
that dumps per-drain state when QUIC_INTEROP_DEBUG=1:
[writer.app] frames=N stream_frames=K streamsView=M active=A
packetBudget_remaining=R connBudget_initial=C
- frames vs stream_frames tells us if non-stream frames (ACK,
MAX_DATA, MAX_STREAM_DATA) are bloating the packet
- active vs streamsView tells us if isClosed filter dropped streams
- packetBudget_remaining tells us if we hit the 64-byte break early
- connBudget_initial tells us if conn flow control was zero
Wired three pieces:
1. WriterDebug.kt — a single @Volatile boolean owned by commonMain,
`writerDebugEnabled`. Off by default.
2. InteropClient.main flips it to true if QUIC_INTEROP_DEBUG=1 is set
in the env.
3. Dockerfile + Makefile accept --build-arg DEBUG=1 (or `make build
DEBUG=1`) to bake the env var into the image.
Usage:
cd quic/interop
make build DEBUG=1
cd ../..
./quic/interop/run-matrix.sh -s aioquic -t multiplexing
cat ../quic-interop-runner/logs/run-*/aioquic_amethyst/multiplexing/output.txt | grep '^\[writer'
When off, cost is one volatile read in the writer hot path — negligible.
https://claude.ai/code/session_01HcvfQq1ttPV9PkRoJb4nyT
34 lines
1.1 KiB
Makefile
34 lines
1.1 KiB
Makefile
# Local iteration loop for the quic-interop-runner endpoint image.
|
|
#
|
|
# make build # compile JVM dist + build Docker image
|
|
# make image-name # print the image tag (for use in implementations_quic.json)
|
|
# make clean # nuke the dist + image
|
|
#
|
|
# Real testing happens via the runner: clone quic-interop-runner separately
|
|
# and drive it with `quic/interop/run-matrix.sh -s <peer> -t <tests>`.
|
|
IMAGE ?= amethyst-quic-interop:latest
|
|
REPO_ROOT := $(shell git rev-parse --show-toplevel)
|
|
DIST_DIR := build/install/quic-interop
|
|
|
|
# Build-time toggle: `make build DEBUG=1` bakes QUIC_INTEROP_DEBUG=1 into
|
|
# the image so the InteropClient + writer emit per-drain diagnostics to
|
|
# stderr. Off by default — production matrix runs stay silent.
|
|
DEBUG ?= 0
|
|
|
|
.PHONY: build dist docker image-name clean
|
|
|
|
build: docker
|
|
|
|
dist:
|
|
cd $(REPO_ROOT) && ./gradlew :quic-interop:installDist
|
|
|
|
docker: dist
|
|
cd $(REPO_ROOT) && docker build -t $(IMAGE) --build-arg DEBUG=$(DEBUG) -f quic/interop/Dockerfile .
|
|
|
|
image-name:
|
|
@echo $(IMAGE)
|
|
|
|
clean:
|
|
cd $(REPO_ROOT) && ./gradlew :quic-interop:clean
|
|
docker image rm -f $(IMAGE) 2>/dev/null || true
|