Files
amethyst/quic
Claude 71e14fe639 chore(quic): audit cleanup — drop redundant copy, rename queue, extract test fixture
Three small follow-ups from the audit pass:

1. Drop redundant `challengeData.copyOf()` in
   `queuePathResponseLocked` — the parser produces a fresh
   ByteArray per PATH_CHALLENGE via `QuicReader.readBytes`'s
   `copyOfRange`, so the defensive copy was a wasted allocation.
   One-line fix.

2. Rename `pendingPathResponses` → `pendingPathChallengePayloads`.
   The queue holds inbound CHALLENGE payloads we owe RESPONSES
   for — old name conflated the two. Pure rename across
   QuicConnection / Parser / Writer / PathValidationTest.

3. Extract shared `newConnectedClient(...)` test fixture
   (`ConnectedClientFixture.kt`). The 6 test files each repeated
   ~40 lines of identical handshake-pipe boilerplate; folded into
   one parameterized helper accepting transport-cap overrides.
   Net −164 lines across the test tree; per-test helper is now a
   one-liner that documents the cap shape.

No behavior change. Full quic suite + amethyst hook test green.

https://claude.ai/code/session_018KPKWRg5baX5Anf7zfEyec
2026-05-08 00:03:47 +00:00
..