nick/amethyst
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Merge pull request #2079 from vitorpamplona/claude/fix-pip-crash-eZBgt

Browse Source 
Clamp PiP aspect ratio to Android system limits
This commit is contained in:
Vitor Pamplona
2026-04-02 15:17:26 -04:00
committed by GitHub
parent 2cb88185e2 0f5cb10a2a
commit 7f64d4ad5a
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
amethyst/src/main/java/com/vitorpamplona/amethyst/service/playback/pip/PictureInPicture.kt
+10 -2
View File
@@ -26,6 +26,14 @@ import android.graphics.Rect
import android.os.Build
import android.util.Rational
private const val MIN_PIP_RATIO = 0.42f
private const val MAX_PIP_RATIO = 2.39f
private fun Float.toPipRational(): Rational {
val clamped = coerceIn(MIN_PIP_RATIO, MAX_PIP_RATIO)
return Rational((clamped * 1000).toInt(), 1000)
}
fun makePipParams(
ratio: Float?,
bounds: Rect?,
@@ -37,7 +45,7 @@ fun makePipParams(
setAutoEnterEnabled(true)
}
bounds?.let { setSourceRectHint(bounds) }
ratio?.let { setAspectRatio(Rational((it * 1000).toInt(), 1000)) }
ratio?.let { setAspectRatio(it.toPipRational()) }
}.build()
fun Activity.makePipParams(
@@ -60,5 +68,5 @@ fun Activity.makePipParams(
),
)
bounds?.let { setSourceRectHint(bounds) }
ratio?.let { setAspectRatio(Rational((it * 1000).toInt(), 1000)) }
ratio?.let { setAspectRatio(it.toPipRational()) }
}.build()