chore: minor cleanups from audit round 3
- Drop two unused strings (git_repo_no_issues, git_repo_no_patches); the default FeedEmpty composable already provides a generic "Feed is empty" + refresh button which is sufficient. - Import MaterialSymbol in GitRepositoryOverview so the LinkLine parameter type isn't a fully-qualified name, per CLAUDE.md style. - Switch two vertical Spacer(Modifier.size(N.dp)) to Modifier.height(N.dp) — functionally identical but conveys intent.
This commit is contained in:
+5
-3
@@ -28,6 +28,7 @@ import androidx.compose.foundation.layout.Row
|
||||
import androidx.compose.foundation.layout.Spacer
|
||||
import androidx.compose.foundation.layout.fillMaxSize
|
||||
import androidx.compose.foundation.layout.fillMaxWidth
|
||||
import androidx.compose.foundation.layout.height
|
||||
import androidx.compose.foundation.layout.padding
|
||||
import androidx.compose.foundation.layout.size
|
||||
import androidx.compose.foundation.rememberScrollState
|
||||
@@ -45,6 +46,7 @@ import androidx.compose.ui.text.style.TextOverflow
|
||||
import androidx.compose.ui.unit.dp
|
||||
import com.vitorpamplona.amethyst.R
|
||||
import com.vitorpamplona.amethyst.commons.icons.symbols.Icon
|
||||
import com.vitorpamplona.amethyst.commons.icons.symbols.MaterialSymbol
|
||||
import com.vitorpamplona.amethyst.commons.icons.symbols.MaterialSymbols
|
||||
import com.vitorpamplona.amethyst.model.LocalCache
|
||||
import com.vitorpamplona.amethyst.ui.components.ClickableUrl
|
||||
@@ -156,7 +158,7 @@ private fun TitleHeader(event: GitRepositoryEvent) {
|
||||
overflow = TextOverflow.Ellipsis,
|
||||
)
|
||||
if (event.isPersonalFork()) {
|
||||
Spacer(Modifier.size(4.dp))
|
||||
Spacer(Modifier.height(4.dp))
|
||||
TopicChip(stringRes(id = R.string.git_repo_personal_fork))
|
||||
}
|
||||
}
|
||||
@@ -182,14 +184,14 @@ private fun SectionCard(
|
||||
color = MaterialTheme.colorScheme.grayText,
|
||||
fontWeight = FontWeight.SemiBold,
|
||||
)
|
||||
Spacer(Modifier.size(8.dp))
|
||||
Spacer(Modifier.height(8.dp))
|
||||
content()
|
||||
}
|
||||
}
|
||||
|
||||
@Composable
|
||||
private fun LinkLine(
|
||||
symbol: com.vitorpamplona.amethyst.commons.icons.symbols.MaterialSymbol,
|
||||
symbol: MaterialSymbol,
|
||||
url: String,
|
||||
) {
|
||||
Row(
|
||||
|
||||
@@ -2079,8 +2079,6 @@
|
||||
<string name="git_repo_section_maintainers">Maintainers</string>
|
||||
<string name="git_repo_section_topics">Topics</string>
|
||||
<string name="git_repo_personal_fork">Personal fork</string>
|
||||
<string name="git_repo_no_issues">No issues for this repository yet.</string>
|
||||
<string name="git_repo_no_patches">No patches or pull requests yet.</string>
|
||||
<string name="nsite_title">Static Website: %1$s</string>
|
||||
<string name="nsite_root_site">Root Site</string>
|
||||
<string name="nsite_source">Source:</string>
|
||||
|
||||
Reference in New Issue
Block a user