Fixes translations from Japanese with urls breaking the url

This commit is contained in:
Vitor Pamplona
2023-07-07 15:30:51 -04:00
parent d35d6a44fe
commit bfbaabd7e8
2 changed files with 17 additions and 4 deletions
@@ -11,17 +11,17 @@ import org.junit.runner.RunWith
@RunWith(AndroidJUnit4::class) @RunWith(AndroidJUnit4::class)
class TranslationsTest { class TranslationsTest {
fun translatePT(text: String, translateTo: String): String? { fun translateTo(text: String, translateTo: String): String? {
val task = LanguageTranslatorService.autoTranslate(text, emptySet(), translateTo) val task = LanguageTranslatorService.autoTranslate(text, emptySet(), translateTo)
return Tasks.await(task).result return Tasks.await(task).result
} }
fun assertTranslate(expected: String, input: String, translateTo: String) { fun assertTranslate(expected: String, input: String, translateTo: String) {
assertEquals(null, expected, translatePT(input, translateTo)) assertEquals(null, expected, translateTo(input, translateTo))
} }
fun assertTranslateContains(expected: String, input: String, translateTo: String) { fun assertTranslateContains(expected: String, input: String, translateTo: String) {
val translated = translatePT(input, translateTo)!! val translated = translateTo(input, translateTo)!!
assertTrue("'$translated' does not contain '$expected'", translated.contains(expected)) assertTrue("'$translated' does not contain '$expected'", translated.contains(expected))
} }
@@ -86,4 +86,17 @@ class TranslationsTest {
"en" "en"
) )
} }
@Test
fun testJapaneseTranslationsOfUrl() {
assertTranslateContains(
"https://youtu.be/wMYFmCDy_Eg",
"うちの会社の小さい先輩の話 第1話「うちの会社の先輩は小さくて可愛い」\n" +
"\n" +
"https://youtu.be/wMYFmCDy_Eg\n" +
"\n" +
"先輩がうざい後輩の話と似たような話かと思ったけど、もっとオタクの妄想あるある的なものを詰め込んだやつだ。ワードとかシチュエーションとか、ヒロインのサイズ感とか。知らんけど",
"en"
)
}
} }
@@ -142,7 +142,7 @@ object LanguageTranslatorService {
val counter = 0 val counter = 0
return urlsInText.filter { !it.originalUrl.contains("") || !it.originalUrl.contains("") }.associate { return urlsInText.filter { !it.originalUrl.contains("") && !it.originalUrl.contains("") }.associate {
"Amethysturlindexer$counter" to it.originalUrl "Amethysturlindexer$counter" to it.originalUrl
} }
} }